Remove unused IsContentUsedElsewhere()

Remove unused IsContentUsedElsewhere()

Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.

Also, PDFPARSE_NOSTREAM is unused.
Then we can remove m_Flags from PARSE_CONTEXT.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/02056fae83c8136195c8eb2a00c3606f600a8b6a

[Tom Sepez, 2016-01-25 19:03:23]

tsepez@chromium.org changed reviewers:
+ ochang@chromium.org, thestig@chromium.org

[Tom Sepez, 2016-01-25 19:03:23]

Oliver, for review.  This may be my favorite CL ever.

[Tom Sepez, 2016-01-25 19:16:47]

Description was changed from

==========
Remove unused IsContentUsedElsewhere()

Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.
==========

to

==========
Remove unused IsContentUsedElsewhere()

Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.

Also, PDFPARSE_NOSTREAM is unused.
Then we can remove the flags member from PARSE_CONTEXT.
==========

[Tom Sepez, 2016-01-25 19:21:56]

Description was changed from

==========
Remove unused IsContentUsedElsewhere()

Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.

Also, PDFPARSE_NOSTREAM is unused.
Then we can remove the flags member from PARSE_CONTEXT.
==========

to

==========
Remove unused IsContentUsedElsewhere()

Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.

Also, PDFPARSE_NOSTREAM is unused.
Then we can remove the flags member from PARSE_CONTEXT.

Also m_DictStart and m_DictEnd are set but never used in
any calculations.  Remove them from PARSE_CONTEXT.
==========

[Tom Sepez, 2016-01-25 19:22:33]

Description was changed from

==========
Remove unused IsContentUsedElsewhere()

Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.

Also, PDFPARSE_NOSTREAM is unused.
Then we can remove the flags member from PARSE_CONTEXT.

Also m_DictStart and m_DictEnd are set but never used in
any calculations.  Remove them from PARSE_CONTEXT.
==========

to

==========
Remove unused IsContentUsedElsewhere()

Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.

Also, PDFPARSE_NOSTREAM is unused.
Then we can remove m_Flags from PARSE_CONTEXT.

Also m_DictStart and m_DictEnd are set but never used in
any calculations.  Remove them from PARSE_CONTEXT.
==========

[Tom Sepez, 2016-01-25 19:26:22]

On 2016/01/25 19:03:23, Tom Sepez wrote:
> Oliver, for review.  This may be my favorite CL ever.
Hang on, the hits just keep on coming.

[Tom Sepez, 2016-01-25 19:41:10]

On 2016/01/25 19:26:22, Tom Sepez wrote:
> On 2016/01/25 19:03:23, Tom Sepez wrote:
> > Oliver, for review.  This may be my favorite CL ever.
> Hang on, the hits just keep on coming.

Ok, lets review this one, the change to full remove PARSE_OPTIONS is getting big
and should be done in its own CL.

[Tom Sepez, 2016-01-25 19:45:08]

Description was changed from

==========
Remove unused IsContentUsedElsewhere()

Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.

Also, PDFPARSE_NOSTREAM is unused.
Then we can remove m_Flags from PARSE_CONTEXT.

Also m_DictStart and m_DictEnd are set but never used in
any calculations.  Remove them from PARSE_CONTEXT.
==========

to

==========
Remove unused IsContentUsedElsewhere()

Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.

Also, PDFPARSE_NOSTREAM is unused.
Then we can remove m_Flags from PARSE_CONTEXT.
==========

[Lei Zhang, 2016-01-25 20:07:14]

lgtm

[Tom Sepez, 2016-01-25 20:15:32]

Description was changed from

==========
Remove unused IsContentUsedElsewhere()

Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.

Also, PDFPARSE_NOSTREAM is unused.
Then we can remove m_Flags from PARSE_CONTEXT.
==========

to

==========
Remove unused IsContentUsedElsewhere()

Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.

Also, PDFPARSE_NOSTREAM is unused.
Then we can remove m_Flags from PARSE_CONTEXT.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/02056fae83c8136195c8eb2a00c3606f600a...
==========

[Tom Sepez, 2016-01-25 20:15:33]

Committed patchset #4 (id:60001) manually as
02056fae83c8136195c8eb2a00c3606f600a8b6a (presubmit successful).