Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1638443003: tracing_controller: Eliminates extra parameter of StartAgentTracingDone (Closed)

Created:
4 years, 11 months ago by charliea (OOO until 10-5)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tracing_controller: Eliminates extra parameter of StartAgentTracingDone The previous implementation obscured the fact that 'callback' and 'on_start_tracing_done_' were actually the same function. Committed: https://crrev.com/e474d3f7554314943b773e256abe75538c313186 Cr-Commit-Position: refs/heads/master@{#371317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M content/browser/tracing/tracing_controller_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 3 chunks +6 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
charliea (OOO until 10-5)
4 years, 11 months ago (2016-01-25 19:18:43 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638443003/1
4 years, 11 months ago (2016-01-25 19:19:31 UTC) #4
oystein (OOO til 10th of July)
lgtm
4 years, 11 months ago (2016-01-25 19:21:17 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 20:37:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638443003/1
4 years, 11 months ago (2016-01-25 21:19:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 21:27:34 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 21:28:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e474d3f7554314943b773e256abe75538c313186
Cr-Commit-Position: refs/heads/master@{#371317}

Powered by Google App Engine
This is Rietveld 408576698