Roll src/third_party/libvpx_new/source/libvpx/ c0307e6ce..732242ab3 (15 commits).

Roll src/third_party/libvpx_new/source/libvpx/ c0307e6ce..732242ab3 (15 commits).

https://chromium.googlesource.com/webm/libvpx.git/+log/c0307e6cea0f..732242ab3d00

$ git log c0307e6ce..732242ab3 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 marpan vp9 pickmode: Fix the shift on negative value.
2016-01-21 jzern vp9_aq_cyclicrefresh: fix double->float warning
2016-01-21 yaowu Fix a typo in ctrl_set_render_size()
2016-01-20 marpan vp9-aqmode=3: Reduce condition below which we turn off delta-qp.
2016-01-20 huisu Fix build with --enable-internal-stats
2016-01-20 aconverse Remove the vestigal skip_eob feature from tokenization.
2016-01-20 marpan vp9-svc: Allow frame-dropping in svc datarate control tests.
2016-01-20 marpan vp8-denoiser: Fix threshold for skin map.
2016-01-20 yaowu Remove duplicate definitions
2016-01-15 marpan Vidyo patch: Changes to the scalability code.
2016-01-19 slavarnway VP9: Eliminate MB_MODE_INFO
2016-01-18 rsbultje Use input framerate as timebase if none was explicitly specified.
2016-01-15 aconverse Tie the bit cost scale to a define.
2016-01-15 aconverse Deduplicate sign cost for ONE/TWO/THREE/FOUR tokens
2016-01-06 yunqingwang Amend and improve VP8 multithreading implementation

R=johannkoenig@google.com

Committed: https://crrev.com/1861c8bff5fa4f60b9078698d7fb9dc936a9914d
Cr-Commit-Position: refs/heads/master@{#371296}

[marpan, 2016-01-25 17:31:15]

Description was changed from

==========
Roll src/third_party/libvpx_new/source/libvpx/ c0307e6ce..732242ab3 (15
commits).

https://chromium.googlesource.com/webm/libvpx.git/+log/c0307e6cea0f..732242ab...

$ git log c0307e6ce..732242ab3 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 marpan vp9 pickmode: Fix the shift on negative value.
2016-01-21 jzern vp9_aq_cyclicrefresh: fix double->float warning
2016-01-21 yaowu Fix a typo in ctrl_set_render_size()
2016-01-20 marpan vp9-aqmode=3: Reduce condition below which we turn off
delta-qp.
2016-01-20 huisu Fix build with --enable-internal-stats
2016-01-20 aconverse Remove the vestigal skip_eob feature from tokenization.
2016-01-20 marpan vp9-svc: Allow frame-dropping in svc datarate control tests.
2016-01-20 marpan vp8-denoiser: Fix threshold for skin map.
2016-01-20 yaowu Remove duplicate definitions
2016-01-15 marpan Vidyo patch: Changes to the scalability code.
2016-01-19 slavarnway VP9: Eliminate MB_MODE_INFO
2016-01-18 rsbultje Use input framerate as timebase if none was explicitly
specified.
2016-01-15 aconverse Tie the bit cost scale to a define.
2016-01-15 aconverse Deduplicate sign cost for ONE/TWO/THREE/FOUR tokens
2016-01-06 yunqingwang Amend and improve VP8 multithreading implementation

R=johannkoenig@google.com
BUG=
==========

to

==========
Roll src/third_party/libvpx_new/source/libvpx/ c0307e6ce..732242ab3 (15
commits).

https://chromium.googlesource.com/webm/libvpx.git/+log/c0307e6cea0f..732242ab...

$ git log c0307e6ce..732242ab3 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 marpan vp9 pickmode: Fix the shift on negative value.
2016-01-21 jzern vp9_aq_cyclicrefresh: fix double->float warning
2016-01-21 yaowu Fix a typo in ctrl_set_render_size()
2016-01-20 marpan vp9-aqmode=3: Reduce condition below which we turn off
delta-qp.
2016-01-20 huisu Fix build with --enable-internal-stats
2016-01-20 aconverse Remove the vestigal skip_eob feature from tokenization.
2016-01-20 marpan vp9-svc: Allow frame-dropping in svc datarate control tests.
2016-01-20 marpan vp8-denoiser: Fix threshold for skin map.
2016-01-20 yaowu Remove duplicate definitions
2016-01-15 marpan Vidyo patch: Changes to the scalability code.
2016-01-19 slavarnway VP9: Eliminate MB_MODE_INFO
2016-01-18 rsbultje Use input framerate as timebase if none was explicitly
specified.
2016-01-15 aconverse Tie the bit cost scale to a define.
2016-01-15 aconverse Deduplicate sign cost for ONE/TWO/THREE/FOUR tokens
2016-01-06 yunqingwang Amend and improve VP8 multithreading implementation

R=johannkoenig@google.com
==========

[marpan, 2016-01-25 17:31:28]

The CQ bit was checked by marpan@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 17:33:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638443002/1

[commit-bot: I haz the power, 2016-01-25 17:33:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 17:33:10]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Tom Finegan, 2016-01-25 17:45:55]

On 2016/01/25 17:33:10, commit-bot: I haz the power wrote:
> Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
> accepted.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

lgtm

[marpan, 2016-01-25 17:46:48]

The CQ bit was checked by marpan@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 17:47:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638443002/1

[commit-bot: I haz the power, 2016-01-25 19:16:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 19:16:06]

Dry run: This issue passed the CQ dry run.

[marpan, 2016-01-25 19:57:37]

The CQ bit was checked by marpan@google.com

[commit-bot: I haz the power, 2016-01-25 20:05:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638443002/1

[commit-bot: I haz the power, 2016-01-25 20:16:25]

Description was changed from

==========
Roll src/third_party/libvpx_new/source/libvpx/ c0307e6ce..732242ab3 (15
commits).

https://chromium.googlesource.com/webm/libvpx.git/+log/c0307e6cea0f..732242ab...

$ git log c0307e6ce..732242ab3 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 marpan vp9 pickmode: Fix the shift on negative value.
2016-01-21 jzern vp9_aq_cyclicrefresh: fix double->float warning
2016-01-21 yaowu Fix a typo in ctrl_set_render_size()
2016-01-20 marpan vp9-aqmode=3: Reduce condition below which we turn off
delta-qp.
2016-01-20 huisu Fix build with --enable-internal-stats
2016-01-20 aconverse Remove the vestigal skip_eob feature from tokenization.
2016-01-20 marpan vp9-svc: Allow frame-dropping in svc datarate control tests.
2016-01-20 marpan vp8-denoiser: Fix threshold for skin map.
2016-01-20 yaowu Remove duplicate definitions
2016-01-15 marpan Vidyo patch: Changes to the scalability code.
2016-01-19 slavarnway VP9: Eliminate MB_MODE_INFO
2016-01-18 rsbultje Use input framerate as timebase if none was explicitly
specified.
2016-01-15 aconverse Tie the bit cost scale to a define.
2016-01-15 aconverse Deduplicate sign cost for ONE/TWO/THREE/FOUR tokens
2016-01-06 yunqingwang Amend and improve VP8 multithreading implementation

R=johannkoenig@google.com
==========

to

==========
Roll src/third_party/libvpx_new/source/libvpx/ c0307e6ce..732242ab3 (15
commits).

https://chromium.googlesource.com/webm/libvpx.git/+log/c0307e6cea0f..732242ab...

$ git log c0307e6ce..732242ab3 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 marpan vp9 pickmode: Fix the shift on negative value.
2016-01-21 jzern vp9_aq_cyclicrefresh: fix double->float warning
2016-01-21 yaowu Fix a typo in ctrl_set_render_size()
2016-01-20 marpan vp9-aqmode=3: Reduce condition below which we turn off
delta-qp.
2016-01-20 huisu Fix build with --enable-internal-stats
2016-01-20 aconverse Remove the vestigal skip_eob feature from tokenization.
2016-01-20 marpan vp9-svc: Allow frame-dropping in svc datarate control tests.
2016-01-20 marpan vp8-denoiser: Fix threshold for skin map.
2016-01-20 yaowu Remove duplicate definitions
2016-01-15 marpan Vidyo patch: Changes to the scalability code.
2016-01-19 slavarnway VP9: Eliminate MB_MODE_INFO
2016-01-18 rsbultje Use input framerate as timebase if none was explicitly
specified.
2016-01-15 aconverse Tie the bit cost scale to a define.
2016-01-15 aconverse Deduplicate sign cost for ONE/TWO/THREE/FOUR tokens
2016-01-06 yunqingwang Amend and improve VP8 multithreading implementation

R=johannkoenig@google.com
==========

[commit-bot: I haz the power, 2016-01-25 20:16:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-25 20:17:26]

Description was changed from

==========
Roll src/third_party/libvpx_new/source/libvpx/ c0307e6ce..732242ab3 (15
commits).

https://chromium.googlesource.com/webm/libvpx.git/+log/c0307e6cea0f..732242ab...

$ git log c0307e6ce..732242ab3 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 marpan vp9 pickmode: Fix the shift on negative value.
2016-01-21 jzern vp9_aq_cyclicrefresh: fix double->float warning
2016-01-21 yaowu Fix a typo in ctrl_set_render_size()
2016-01-20 marpan vp9-aqmode=3: Reduce condition below which we turn off
delta-qp.
2016-01-20 huisu Fix build with --enable-internal-stats
2016-01-20 aconverse Remove the vestigal skip_eob feature from tokenization.
2016-01-20 marpan vp9-svc: Allow frame-dropping in svc datarate control tests.
2016-01-20 marpan vp8-denoiser: Fix threshold for skin map.
2016-01-20 yaowu Remove duplicate definitions
2016-01-15 marpan Vidyo patch: Changes to the scalability code.
2016-01-19 slavarnway VP9: Eliminate MB_MODE_INFO
2016-01-18 rsbultje Use input framerate as timebase if none was explicitly
specified.
2016-01-15 aconverse Tie the bit cost scale to a define.
2016-01-15 aconverse Deduplicate sign cost for ONE/TWO/THREE/FOUR tokens
2016-01-06 yunqingwang Amend and improve VP8 multithreading implementation

R=johannkoenig@google.com
==========

to

==========
Roll src/third_party/libvpx_new/source/libvpx/ c0307e6ce..732242ab3 (15
commits).

https://chromium.googlesource.com/webm/libvpx.git/+log/c0307e6cea0f..732242ab...

$ git log c0307e6ce..732242ab3 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 marpan vp9 pickmode: Fix the shift on negative value.
2016-01-21 jzern vp9_aq_cyclicrefresh: fix double->float warning
2016-01-21 yaowu Fix a typo in ctrl_set_render_size()
2016-01-20 marpan vp9-aqmode=3: Reduce condition below which we turn off
delta-qp.
2016-01-20 huisu Fix build with --enable-internal-stats
2016-01-20 aconverse Remove the vestigal skip_eob feature from tokenization.
2016-01-20 marpan vp9-svc: Allow frame-dropping in svc datarate control tests.
2016-01-20 marpan vp8-denoiser: Fix threshold for skin map.
2016-01-20 yaowu Remove duplicate definitions
2016-01-15 marpan Vidyo patch: Changes to the scalability code.
2016-01-19 slavarnway VP9: Eliminate MB_MODE_INFO
2016-01-18 rsbultje Use input framerate as timebase if none was explicitly
specified.
2016-01-15 aconverse Tie the bit cost scale to a define.
2016-01-15 aconverse Deduplicate sign cost for ONE/TWO/THREE/FOUR tokens
2016-01-06 yunqingwang Amend and improve VP8 multithreading implementation

R=johannkoenig@google.com

Committed: https://crrev.com/1861c8bff5fa4f60b9078698d7fb9dc936a9914d
Cr-Commit-Position: refs/heads/master@{#371296}
==========

[commit-bot: I haz the power, 2016-01-25 20:17:27]

Patchset 1 (id:??) landed as
https://crrev.com/1861c8bff5fa4f60b9078698d7fb9dc936a9914d
Cr-Commit-Position: refs/heads/master@{#371296}

[marpan, 2016-01-26 03:43:13]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1638533003/ by marpan@google.com.

The reason for reverting is: Breaking win build in webrtc:
https://codereview.webrtc.org/1637793002/
.

[Nico, 2016-01-26 15:29:06]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-01-26 15:29:07]

FYI, this also broke the clang/win build with gn like so:

FAILED: ninja -t msvc -e environment.x64 --
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC @obj/third_party/libvpx_new/libvpx_new/threading.obj.rsp /c
../../third_party/libvpx_new/source/libvpx/vp8/decoder/threading.c
/Foobj/third_party/libvpx_new/libvpx_new/threading.obj
/Fdobj/third_party/libvpx_new/libvpx_new_c.pdb
../../third_party/libvpx_new/source/libvpx/vp8/decoder/threading.c(687,65) : 
error: incompatible pointer types passing 'DWORD (void *)
__attribute__((stdcall))' (aka 'unsigned long (void *)') to parameter of type
'unsigned int (*)(void *) __attribute__((stdcall))'
[-Werror,-Wincompatible-pointer-types]
            pthread_create(&pbi->h_decoding_thread[ithread], 0,
thread_decoding_proc, (&pbi->de_thread_data[ithread]));
                                                               
^~~~~~~~~~~~~~~~~~~~
../../third_party/libvpx_new/source/libvpx\vpx_util/vpx_thread.h(51,59) :  note:
passing argument to parameter 'start' here
                                 unsigned int (__stdcall *start)(void*),
                                                          ^
1 error generated.
FAILED: ninja -t msvc -e environment.x64 --
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC @obj/third_party/libvpx_new/libvpx_new/ethreading.obj.rsp /c
../../third_party/libvpx_new/source/libvpx/vp8/encoder/ethreading.c
/Foobj/third_party/libvpx_new/libvpx_new/ethreading.obj
/Fdobj/third_party/libvpx_new/libvpx_new_c.pdb
../../third_party/libvpx_new/source/libvpx/vp8/encoder/ethreading.c(580,33) : 
error: incompatible pointer types passing 'DWORD (void *)
__attribute__((stdcall))' (aka 'unsigned long (void *)') to parameter of type
'unsigned int (*)(void *) __attribute__((stdcall))'
[-Werror,-Wincompatible-pointer-types]
                                thread_encoding_proc, ethd);
                                ^~~~~~~~~~~~~~~~~~~~
../../third_party/libvpx_new/source/libvpx\vpx_util/vpx_thread.h(51,59) :  note:
passing argument to parameter 'start' here
                                 unsigned int (__stdcall *start)(void*),
                                                          ^
../../third_party/libvpx_new/source/libvpx/vp8/encoder/ethreading.c(615,59) : 
error: incompatible pointer types passing 'DWORD (void *)
__attribute__((stdcall))' (aka 'unsigned long (void *)') to parameter of type
'unsigned int (*)(void *) __attribute__((stdcall))'
[-Werror,-Wincompatible-pointer-types]
            rc = pthread_create(&cpi->h_filter_thread, 0, thread_loopfilter,
                                                          ^~~~~~~~~~~~~~~~~
../../third_party/libvpx_new/source/libvpx\vpx_util/vpx_thread.h(51,59) :  note:
passing argument to parameter 'start' here
                                 unsigned int (__stdcall *start)(void*),
                                                          ^
2 errors generated.

Please fix these too before relanding.