Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1638433002: Another check for null LayoutView in PaintLayerCompositor::updateIfNeededRecursive() (Closed)

Created:
4 years, 11 months ago by Xianzhu
Modified:
4 years, 11 months ago
Reviewers:
chrishtr, pdr.
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Another check for null LayoutView in PaintLayerCompositor::updateIfNeededRecursive() BUG=580978 Committed: https://crrev.com/633e689b520b25f3e264a2ede6b74ccc23cb636a Cr-Commit-Position: refs/heads/master@{#371461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Xianzhu
Similar to https://codereview.chromium.org/1614493003/, no new test because I couldn't reproduce the bug.
4 years, 11 months ago (2016-01-25 17:27:28 UTC) #2
Xianzhu
4 years, 11 months ago (2016-01-25 18:35:08 UTC) #4
pdr.
On 2016/01/25 at 18:35:08, wangxianzhu wrote: > I spent a minute trying to figure out ...
4 years, 11 months ago (2016-01-26 03:43:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638433002/1
4 years, 11 months ago (2016-01-26 03:44:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 05:08:34 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 05:09:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/633e689b520b25f3e264a2ede6b74ccc23cb636a
Cr-Commit-Position: refs/heads/master@{#371461}

Powered by Google App Engine
This is Rietveld 408576698