chrome/test/data/password/form_and_link.html - Issue 163843002: Fix check for user gesture on password autofill

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/password/form_and_link.html

Issue 163843002: Fix check for user gesture on password autofill (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix compilation Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/password_manager/password_manager_browsertest.cc ('K') | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | components/autofill/content/renderer/password_autofill_agent.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <body>	2 <body>

3	3 <form method="POST" action="done.html" id="testform">

4 <iframe src="password_form.html" id="first_frame" name="first_frame">
jww 2014/02/18 20:19:56 I'm pretty confused about why you're deleting thes I'm pretty confused about why you're deleting these frames. It seems like you're renaming multi_frames.html, in which case these frames are still being used by several browser tests. Am I misunderstanding what's going on here? vabr (Chromium) 2014/02/19 07:56:39 I'm actually not touching multi_frames.html at all Show quoted text On 2014/02/18 20:19:56, jww wrote: > I'm pretty confused about why you're deleting these frames. It seems like you're > renaming multi_frames.html, in which case these frames are still being used by > several browser tests. Am I misunderstanding what's going on here? I'm actually not touching multi_frames.html at all (you would see it marked as deleted here), git just knows that I created form_and_link.html as a copy of multi_frames.html, and then edited it. I could try to force git into not thinking so, on the other hand git is precisely right about how I created the file, so I'm not sure if this is a problem.
5 </iframe>

6 <iframe src="password_form.html" id="second_frame" name="second_frame">

7 </iframe>

8

9 <form method="POST" action="done.html" onsubmit="return false;" id="testform">

10 <input type="text" id="username_field" name="username_field">	4 <input type="text" id="username_field" name="username_field">

11 <input type="password" id="password_field" name="password_field">	5 <input type="password" id="password_field" name="password_field">

12 <input type="submit" id="input_submit_button" name="input_submit_button">	6 <input type="submit" id="input_submit_button" name="input_submit_button">

13 </form>	7 </form>

14	8 <a href="done.html" id="testlink" target="_blank">Link</a>

15 </body>	9 </body>

16 </html>	10 </html>

OLD	NEW