Use list instead of pair to represent the set of displays.

Use list instead of pair to represent the set of displays.

BUG=582491
Committed: https://crrev.com/4763f82427f659255546657d7e94b166f2d9a405
Cr-Commit-Position: refs/heads/master@{#372736}

[oshima, 2016-01-29 17:29:48]

Description was changed from

==========
DisplayIdList

BUG=
==========

to

==========
Use list instead of pair to represent the set of displays.

BUG=582491
==========

[oshima, 2016-01-29 17:29:48]

oshima@chromium.org changed reviewers:
+ stevenjb@chromium.org

[oshima, 2016-01-29 17:29:55]

Patchset #1 (id:1) has been deleted

[oshima, 2016-01-29 17:30:00]

Patchset #1 (id:20001) has been deleted

[oshima, 2016-01-29 17:30:04]

Patchset #1 (id:40001) has been deleted

[oshima, 2016-01-29 18:19:23]

this is mechanical change from pair to list

[oshima, 2016-01-29 18:19:29]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 18:20:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638413007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638413007/60001

[commit-bot: I haz the power, 2016-01-29 18:39:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 18:39:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2016-01-29 19:15:02]

lgtm

https://codereview.chromium.org/1638413007/diff/60001/ash/display/display_lay...
File ash/display/display_layout_store.cc (right):

https://codereview.chromium.org/1638413007/diff/60001/ash/display/display_lay...
ash/display/display_layout_store.cc:48: void
DisplayLayoutStore::RegisterLayoutForDisplayIdList(
nit: This could remain RegisterLayoutForDisplayIdPair since it (currently) takes
a pair as input.

https://codereview.chromium.org/1638413007/diff/60001/ash/display/display_uti...
File ash/display/display_util.cc (right):

https://codereview.chromium.org/1638413007/diff/60001/ash/display/display_uti...
ash/display/display_util.cc:362: return base::Int64ToString(list[0]) + "," +
base::Int64ToString(list[1]);
Maybe generalize this now?

[oshima, 2016-02-01 18:23:56]

On 2016/01/29 19:15:02, stevenjb wrote:
> lgtm
> 
>
https://codereview.chromium.org/1638413007/diff/60001/ash/display/display_lay...
> File ash/display/display_layout_store.cc (right):
> 
>
https://codereview.chromium.org/1638413007/diff/60001/ash/display/display_lay...
> ash/display/display_layout_store.cc:48: void
> DisplayLayoutStore::RegisterLayoutForDisplayIdList(
> nit: This could remain RegisterLayoutForDisplayIdPair since it (currently)
takes
> a pair as input.
> 
>
https://codereview.chromium.org/1638413007/diff/60001/ash/display/display_uti...
> File ash/display/display_util.cc (right):
> 
>
https://codereview.chromium.org/1638413007/diff/60001/ash/display/display_uti...
> ash/display/display_util.cc:362: return base::Int64ToString(list[0]) + "," +
> base::Int64ToString(list[1]);
> Maybe generalize this now?

I'll address this per offline chat.

[oshima, 2016-02-01 18:24:06]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-02-01 18:24:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1638413007/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-02-01 18:24:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638413007/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638413007/80001

[commit-bot: I haz the power, 2016-02-01 18:41:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 18:41:53]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-02-01 19:29:07]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-02-01 19:29:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1638413007/#ps100001
(title: "fix build error")

[commit-bot: I haz the power, 2016-02-01 19:29:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638413007/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638413007/100001

[commit-bot: I haz the power, 2016-02-01 20:19:27]

Description was changed from

==========
Use list instead of pair to represent the set of displays.

BUG=582491
==========

to

==========
Use list instead of pair to represent the set of displays.

BUG=582491
==========

[commit-bot: I haz the power, 2016-02-01 20:19:28]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-02-01 20:21:33]

Description was changed from

==========
Use list instead of pair to represent the set of displays.

BUG=582491
==========

to

==========
Use list instead of pair to represent the set of displays.

BUG=582491

Committed: https://crrev.com/4763f82427f659255546657d7e94b166f2d9a405
Cr-Commit-Position: refs/heads/master@{#372736}
==========

[commit-bot: I haz the power, 2016-02-01 20:21:34]

Patchset 3 (id:??) landed as
https://crrev.com/4763f82427f659255546657d7e94b166f2d9a405
Cr-Commit-Position: refs/heads/master@{#372736}

[msw, 2016-02-02 22:54:09]

msw@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2016-02-02 22:54:10]

https://codereview.chromium.org/1638413007/diff/100001/ash/shelf/shelf_layout...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/1638413007/diff/100001/ash/shelf/shelf_layout...
ash/shelf/shelf_layout_manager.cc:708: LOG(ERROR) << "Status Area Widget
Bounds:"
Did you mean to land this? It's spamming logs, like this:
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...