Issue 16384005: Update gyp from 1563 to 1643.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16384005: Update gyp from 1563 to 1643. (Closed)

Created:
7 years, 6 months ago by bungeman-skia

Modified:
7 years, 6 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Update gyp from 1563 to 1643. Due to gyp r1584 ( https://code.google.com/p/gyp/source/detail?r=1584 ) gyp no longer automatically provides system libraries on Windows. These now need to be added explicitly. See Chromium r182699 ( http://src.chromium.org/viewvc/chrome?view=revision&revision=182699 ) for the Chromium change related to this gyp change. A similar Skia change is proposed.

Patch Set 1 #

Patch Set 2 : Windows #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/common_conditions.gypi	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	third_party/externals	View	1	0 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

Our gyp is getting old, and I just landed a fix in gyp I want ...

7 years, 6 months ago (2013-06-04 22:44:23 UTC) #1

bungeman-skia

The commit of patch set #1 was reverted with r9448 due to failures on Windows. ...

7 years, 6 months ago (2013-06-05 18:18:51 UTC) #4

bungeman-skia

7 years, 6 months ago (2013-06-06 20:42:57 UTC) #6

Message was sent while issue was closed.

On 2013/06/06 17:11:20, bungeman1 wrote:
> Committed revision 9450.

See also revision 9463 for a follow on change need for building with angle using
ninja on Windows.

Expand Messages | Collapse Messages