Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 1638353002: [fullcodegen] Cleanup MustCreateObjectLiteralWithRuntime. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Cleanup MustCreateObjectLiteralWithRuntime. This cleans up the aforementioned predicate to not rely on the flags computed for communication between compiled code and the runtime. The underlying predicates of the AST are used directly instead. R=mvstanton@chromium.org Committed: https://crrev.com/d211cf24a0cc23395716962727d53713631d7e9b Cr-Commit-Position: refs/heads/master@{#33559}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/ast/ast.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
4 years, 11 months ago (2016-01-27 12:33:29 UTC) #1
mvstanton
Now *thats* a clean up. thx, man. LGTM.
4 years, 11 months ago (2016-01-27 12:46:17 UTC) #2
Michael Starzinger
Thanks. Rebased. Landing.
4 years, 11 months ago (2016-01-27 17:45:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638353002/20001
4 years, 11 months ago (2016-01-27 18:08:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-27 18:16:02 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 18:16:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d211cf24a0cc23395716962727d53713631d7e9b
Cr-Commit-Position: refs/heads/master@{#33559}

Powered by Google App Engine
This is Rietveld 408576698