Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1638303008: [for-in] Ensure that we learn from deopts within for-in loop bodies. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[for-in] Ensure that we learn from deopts within for-in loop bodies. If we deoptimize from TurboFan or Crankshaft into the body of a for-in loop and that for-in mode then switches to slow mode (i.e. has to call %ForInFilter), we have to record that feedback, because otherwise we might actually OSR into that loop assuming that it's fast mode still, or even worse recompile the function later when we call it again w/o having rerun the for-in loop in fullcodegen from the beginning (where was previously the only place we could learn). R=mstarzinger@chromium.org BUG=v8:3650 LOG=n Committed: https://crrev.com/0637f5f64c3bc5d8fc930e65730b7d86cce7a74c Cr-Commit-Position: refs/heads/master@{#33612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -7 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +11 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +11 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +11 lines, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +11 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +11 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +11 lines, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-01-29 11:57:41 UTC) #1
Benedikt Meurer
Hey Michi, Less deopt loops are best deopt loops. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-01-29 11:58:42 UTC) #2
Michael Starzinger
LGTM.
4 years, 10 months ago (2016-01-29 12:27:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638303008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638303008/1
4 years, 10 months ago (2016-01-29 12:28:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 12:30:05 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 12:30:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0637f5f64c3bc5d8fc930e65730b7d86cce7a74c
Cr-Commit-Position: refs/heads/master@{#33612}

Powered by Google App Engine
This is Rietveld 408576698