Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1638303006: Fix ninja wrapper to work on MINGW64 (Closed)

Created:
4 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
Nico, M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix ninja wrapper to work on MINGW64 Small fix that makes it possible to use ninja and depot-tools using the mingw64 chroot bundled in git 2.7.0 With this change I can build succesfully on Windows and still have a civilized shell. BUG= TBR=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298454

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ninja View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Primiano Tucci (use gerrit)
4 years, 10 months ago (2016-01-28 19:51:12 UTC) #2
Nico
lgtm
4 years, 10 months ago (2016-01-28 19:52:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638303006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638303006/1
4 years, 10 months ago (2016-01-28 19:54:47 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 19:56:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298454

Powered by Google App Engine
This is Rietveld 408576698