Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1638303005: MIPS64: Eliminate ABI-dependent definitions. (Closed)

Created:
4 years, 10 months ago by Ilija.Pavlovic1
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Eliminate ABI-dependent definitions. Compilation dependencies for O32 ABI are removed from the code and now compilation will be done according n64 ABI only. TEST= BUG= Committed: https://crrev.com/dd64a6d8a1ead06a67490c869ab4fdd13ac80b00 Cr-Commit-Position: refs/heads/master@{#33589}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -185 lines) Patch
M src/mips64/code-stubs-mips64.cc View 3 chunks +23 lines, -60 lines 0 comments Download
M src/mips64/constants-mips64.h View 2 chunks +1 line, -22 lines 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/mips64/simulator-mips64.h View 3 chunks +0 lines, -28 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 5 chunks +12 lines, -20 lines 0 comments Download
M src/regexp/mips64/regexp-macro-assembler-mips64.h View 3 chunks +1 line, -39 lines 0 comments Download
M src/regexp/mips64/regexp-macro-assembler-mips64.cc View 1 chunk +1 line, -4 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
Ilija.Pavlovic1
PTAL
4 years, 10 months ago (2016-01-28 12:20:04 UTC) #2
balazs.kilvady
LGTM with a small nit. https://codereview.chromium.org/1638303005/diff/1/src/regexp/mips64/regexp-macro-assembler-mips64.cc File src/regexp/mips64/regexp-macro-assembler-mips64.cc (right): https://codereview.chromium.org/1638303005/diff/1/src/regexp/mips64/regexp-macro-assembler-mips64.cc#newcode674 src/regexp/mips64/regexp-macro-assembler-mips64.cc:674: argument_registers |= a4.bit() | ...
4 years, 10 months ago (2016-01-28 12:48:23 UTC) #3
Ilija.Pavlovic1
https://codereview.chromium.org/1638303005/diff/1/src/regexp/mips64/regexp-macro-assembler-mips64.cc File src/regexp/mips64/regexp-macro-assembler-mips64.cc (right): https://codereview.chromium.org/1638303005/diff/1/src/regexp/mips64/regexp-macro-assembler-mips64.cc#newcode674 src/regexp/mips64/regexp-macro-assembler-mips64.cc:674: argument_registers |= a4.bit() | a5.bit() | a6.bit() | a7.bit(); ...
4 years, 10 months ago (2016-01-28 15:07:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638303005/1
4 years, 10 months ago (2016-01-28 15:11:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 16:03:46 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 16:04:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd64a6d8a1ead06a67490c869ab4fdd13ac80b00
Cr-Commit-Position: refs/heads/master@{#33589}

Powered by Google App Engine
This is Rietveld 408576698