Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 163823002: Revert of add peekPixels to SkCanvas and SkSurface (Closed)

Created:
6 years, 10 months ago by reed2
Modified:
6 years, 10 months ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of add peekPixels to SkCanvas and SkSurface (https://codereview.chromium.org/161733002/) Reason for revert: compile issues with gm/xfermodes3 Original issue's description: > add peekPixels to SkCanvas and SkSurface > > clone of https://codereview.chromium.org/159723006/ > > Committed: https://code.google.com/p/skia/source/detail?r=13427 TBR= NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -403 lines) Patch
M gm/aaclip.cpp View 3 chunks +214 lines, -5 lines 0 comments Download
M gm/bitmapcopy.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M gm/bitmapsource.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/deviceproperties.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/displacement.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M gm/gammatext.cpp View 2 chunks +6 lines, -14 lines 0 comments Download
M gm/gm.h View 1 chunk +2 lines, -1 line 0 comments Download
M gm/imagefiltersclipped.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M gm/lighting.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/morphology.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/ninepatchstretch.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M gm/offsetimagefilter.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
D gm/peekpixels.cpp View 1 chunk +0 lines, -78 lines 0 comments Download
M gm/tileimagefilter.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkBitmap.h View 1 chunk +0 lines, -7 lines 0 comments Download
M include/core/SkBitmapDevice.h View 2 chunks +0 lines, -3 lines 0 comments Download
M include/core/SkCanvas.h View 5 chunks +4 lines, -73 lines 0 comments Download
M include/core/SkDevice.h View 2 chunks +1 line, -10 lines 0 comments Download
M include/core/SkSurface.h View 1 chunk +0 lines, -12 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M samplecode/SampleCircle.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M samplecode/SampleLayers.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +0 lines, -49 lines 0 comments Download
M src/core/SkDevice.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/image/SkImagePriv.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/image/SkSurface.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/SkpSkGrTest.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M tests/SurfaceTest.cpp View 4 chunks +17 lines, -82 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reed2
Created Revert of add peekPixels to SkCanvas and SkSurface
6 years, 10 months ago (2014-02-13 15:21:39 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 15:21:51 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-13 15:21:51 UTC) #3
jvanverth1
On 2014/02/13 15:21:51, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 10 months ago (2014-02-13 15:25:24 UTC) #4
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 10 months ago (2014-02-13 15:28:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/163823002/1
6 years, 10 months ago (2014-02-13 15:28:34 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 15:29:16 UTC) #7
Message was sent while issue was closed.
Change committed as 13428

Powered by Google App Engine
This is Rietveld 408576698