Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: components/safe_browsing_db/util.cc

Issue 1638223003: Add support for a module whitelist (goog-whitemodule-digest256) to the safe browsing db (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add method to access the whitelist + unit tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/util.cc
diff --git a/components/safe_browsing_db/util.cc b/components/safe_browsing_db/util.cc
index a7912e0c315bce6c14bec825f220a3c8949071b5..867a7ae2444920cd3c7e01f88d778dd2cd5c4853 100644
--- a/components/safe_browsing_db/util.cc
+++ b/components/safe_browsing_db/util.cc
@@ -50,17 +50,12 @@ const char kExtensionBlacklist[] = "goog-badcrxids-digestvar";
const char kIPBlacklist[] = "goog-badip-digest256";
const char kUnwantedUrlList[] = "goog-unwanted-shavar";
const char kInclusionWhitelist[] = "goog-csdinclusionwhite-sha256";
+const char kModuleWhitelist[] = "goog-whitemodule-sha256";
Nathan Parker 2016/02/16 21:20:53 Is this the right name, rather than "goog-modulewh
proberge 2016/02/16 22:30:17 The right name is goog-whitemodule-digest256. Sorr
-const char* kAllLists[9] = {
- kMalwareList,
- kPhishingList,
- kBinUrlList,
- kCsdWhiteList,
- kDownloadWhiteList,
- kExtensionBlacklist,
- kIPBlacklist,
- kUnwantedUrlList,
- kInclusionWhitelist,
+const char* kAllLists[10] = {
+ kMalwareList, kPhishingList, kBinUrlList, kCsdWhiteList,
+ kDownloadWhiteList, kExtensionBlacklist, kIPBlacklist, kUnwantedUrlList,
+ kInclusionWhitelist, kModuleWhitelist,
};
ListType GetListId(const base::StringPiece& name) {
@@ -83,6 +78,8 @@ ListType GetListId(const base::StringPiece& name) {
id = UNWANTEDURL;
} else if (name == kInclusionWhitelist) {
id = INCLUSIONWHITELIST;
+ } else if (name == kModuleWhitelist) {
+ id = MODULEWHITELIST;
} else {
id = INVALID;
}
@@ -118,6 +115,9 @@ bool GetListName(ListType list_id, std::string* list) {
case INCLUSIONWHITELIST:
*list = kInclusionWhitelist;
break;
+ case MODULEWHITELIST:
+ *list = kModuleWhitelist;
+ break;
default:
return false;
}
« components/safe_browsing_db/database_manager.h ('K') | « components/safe_browsing_db/util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698