Add support for a module whitelist (goog-whitemodule-digest256) to the safe browsing db

Add support for a module whitelist (goog-whitemodule-digest256) to the safe browsing db

BUG=585123
Committed: https://crrev.com/a933956f59c648142b325d431a9d21f167e0d596
Cr-Commit-Position: refs/heads/master@{#375925}

[proberge, 2016-01-27 14:54:26]

Description was changed from

==========
Add support for a module whitelist (goog-whitemodule-sha256) to the safe
browsing db

BUG=
==========

to

==========
Add support for a module whitelist (goog-whitemodule-sha256) to the safe
browsing db

BUG=
==========

[proberge, 2016-01-27 14:54:26]

proberge@chromium.org changed reviewers:
+ nparker@chromium.org

[proberge, 2016-01-27 14:55:09]

Won't be submitted until goog-whitemodule-sha256 starts being served.

[Nathan Parker, 2016-02-08 02:47:40]

Please add a bug number

vakh -- FYI.  This is adding a new whitelist to the DB, to whitelist DLLs for
ward's detection/reporting.

https://codereview.chromium.org/1638223003/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/util.cc (right):

https://codereview.chromium.org/1638223003/diff/1/components/safe_browsing_db...
components/safe_browsing_db/util.cc:56: kMalwareList,        kPhishingList,     
 kBinUrlList,  kCsdWhiteList,
Is this clang-autoformat's work?  I think either that or vertical would be best.

[Nathan Parker, 2016-02-08 02:48:08]

+vakh for real this time.
vakh -- FYI.  This is adding a new whitelist to the DB, to whitelist DLLs for
Ward's detection/reporting.

[Nathan Parker, 2016-02-08 02:58:46]

one comment I missed.

https://codereview.chromium.org/1638223003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/local_database_manager.h (right):

https://codereview.chromium.org/1638223003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/local_database_manager.h:348: bool
enable_module_whitelist_;
Do you  need this?

[proberge, 2016-02-08 16:23:35]

Description was changed from

==========
Add support for a module whitelist (goog-whitemodule-sha256) to the safe
browsing db

BUG=
==========

to

==========
Add support for a module whitelist (goog-whitemodule-sha256) to the safe
browsing db

BUG=585123
==========

[proberge, 2016-02-08 16:23:59]

Added a method to read from the whitelist as well as a unit test. PTAL

https://codereview.chromium.org/1638223003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/local_database_manager.h (right):

https://codereview.chromium.org/1638223003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/local_database_manager.h:348: bool
enable_module_whitelist_;
On 2016/02/08 02:58:46, nparker wrote:
> Do you  need this?

It seems like the standard way of supporting lists.
It's now used by this class's MatchModuleWhitelistString public method.

https://codereview.chromium.org/1638223003/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/util.cc (right):

https://codereview.chromium.org/1638223003/diff/1/components/safe_browsing_db...
components/safe_browsing_db/util.cc:56: kMalwareList,        kPhishingList,     
 kBinUrlList,  kCsdWhiteList,
On 2016/02/08 02:47:40, nparker wrote:
> Is this clang-autoformat's work?  I think either that or vertical would be
best.

Yes, it was autoformat.

[Nathan Parker, 2016-02-16 21:20:53]

lgtm

https://codereview.chromium.org/1638223003/diff/20001/components/safe_browsin...
File components/safe_browsing_db/database_manager.h (right):

https://codereview.chromium.org/1638223003/diff/20001/components/safe_browsin...
components/safe_browsing_db/database_manager.h:121: // Check if |str| matches
any of the full-length hashes from the module
Add a line describing |str|'s format, and describe how this is used, so
new-comers to this code will have context.  "module" is rather vague.

https://codereview.chromium.org/1638223003/diff/20001/components/safe_browsin...
File components/safe_browsing_db/util.cc (right):

https://codereview.chromium.org/1638223003/diff/20001/components/safe_browsin...
components/safe_browsing_db/util.cc:53: const char kModuleWhitelist[] =
"goog-whitemodule-sha256";
Is this the right name, rather than "goog-modulewhite-sha256"?  The other have
"white" at the end.

[proberge, 2016-02-16 22:29:57]

Description was changed from

==========
Add support for a module whitelist (goog-whitemodule-sha256) to the safe
browsing db

BUG=585123
==========

to

==========
Add support for a module whitelist (goog-whitemodule-digest256) to the safe
browsing db

BUG=585123
==========

[proberge, 2016-02-16 22:30:17]

Thanks for the review!

https://codereview.chromium.org/1638223003/diff/20001/components/safe_browsin...
File components/safe_browsing_db/database_manager.h (right):

https://codereview.chromium.org/1638223003/diff/20001/components/safe_browsin...
components/safe_browsing_db/database_manager.h:121: // Check if |str| matches
any of the full-length hashes from the module
On 2016/02/16 21:20:53, nparker wrote:
> Add a line describing |str|'s format, and describe how this is used, so
> new-comers to this code will have context.  "module" is rather vague.

Done.

https://codereview.chromium.org/1638223003/diff/20001/components/safe_browsin...
File components/safe_browsing_db/util.cc (right):

https://codereview.chromium.org/1638223003/diff/20001/components/safe_browsin...
components/safe_browsing_db/util.cc:53: const char kModuleWhitelist[] =
"goog-whitemodule-sha256";
On 2016/02/16 21:20:53, nparker wrote:
> Is this the right name, rather than "goog-modulewhite-sha256"?  The other have
> "white" at the end.

The right name is goog-whitemodule-digest256. Sorry for the inconsistency.

[proberge, 2016-02-16 22:30:56]

The CQ bit was checked by proberge@chromium.org

[proberge, 2016-02-16 22:30:57]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1638223003/#ps40001
(title: "Rename to digest256, add comment to database_manager.h")

[commit-bot: I haz the power, 2016-02-16 22:34:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638223003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638223003/40001

[commit-bot: I haz the power, 2016-02-16 22:57:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 22:57:31]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[proberge, 2016-02-17 14:50:53]

The CQ bit was checked by proberge@chromium.org

[proberge, 2016-02-17 14:50:54]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1638223003/#ps80001
(title: "Reorder case for consistency")

[commit-bot: I haz the power, 2016-02-17 14:51:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638223003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638223003/80001

[commit-bot: I haz the power, 2016-02-17 15:05:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 15:05:55]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[proberge, 2016-02-17 15:12:09]

The CQ bit was checked by proberge@chromium.org

[proberge, 2016-02-17 15:12:09]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1638223003/#ps100001
(title: "Fix Android build by adding dummy method to RemoteDatabaseManager"")

[commit-bot: I haz the power, 2016-02-17 15:12:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638223003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638223003/100001

[commit-bot: I haz the power, 2016-02-17 15:15:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 15:15:06]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[proberge, 2016-02-17 16:11:06]

The CQ bit was checked by proberge@chromium.org

[proberge, 2016-02-17 16:11:07]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1638223003/#ps120001
(title: "Rebase-update because remote_database_manager was moved to components")

[commit-bot: I haz the power, 2016-02-17 16:11:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638223003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638223003/120001

[commit-bot: I haz the power, 2016-02-17 16:25:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 16:25:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[proberge, 2016-02-17 17:36:37]

The CQ bit was checked by proberge@chromium.org

[proberge, 2016-02-17 17:36:38]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1638223003/#ps140001
(title: "Fix browser test")

[commit-bot: I haz the power, 2016-02-17 17:37:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638223003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638223003/140001

[commit-bot: I haz the power, 2016-02-17 18:40:34]

Description was changed from

==========
Add support for a module whitelist (goog-whitemodule-digest256) to the safe
browsing db

BUG=585123
==========

to

==========
Add support for a module whitelist (goog-whitemodule-digest256) to the safe
browsing db

BUG=585123
==========

[commit-bot: I haz the power, 2016-02-17 18:40:37]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-02-17 18:41:39]

Description was changed from

==========
Add support for a module whitelist (goog-whitemodule-digest256) to the safe
browsing db

BUG=585123
==========

to

==========
Add support for a module whitelist (goog-whitemodule-digest256) to the safe
browsing db

BUG=585123

Committed: https://crrev.com/a933956f59c648142b325d431a9d21f167e0d596
Cr-Commit-Position: refs/heads/master@{#375925}
==========

[commit-bot: I haz the power, 2016-02-17 18:41:40]

Patchset 8 (id:??) landed as
https://crrev.com/a933956f59c648142b325d431a9d21f167e0d596
Cr-Commit-Position: refs/heads/master@{#375925}