Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1638213004: Use SET_NESTED_VAR instead of SET_VAR where possible in ComputedStyle (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SET_NESTED_VAR instead of SET_VAR where possible in ComputedStyle In some cases this could save a copy of the outer object (rareNonInheritedData in all cases.) This also saves almost 3.5k of binary footprint. BUG=581413 Committed: https://crrev.com/c3cc873a6da53339da9bf7b9f58d1f43cdee9114 Cr-Commit-Position: refs/heads/master@{#371860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -59 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 7 chunks +59 lines, -59 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
"The rest" Didn't even consider the binary size change before, but that could even be ...
4 years, 10 months ago (2016-01-27 17:35:47 UTC) #2
pdr.
On 2016/01/27 at 17:35:47, fs wrote: > "The rest" > > Didn't even consider the ...
4 years, 10 months ago (2016-01-27 19:12:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638213004/1
4 years, 10 months ago (2016-01-27 19:14:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-27 20:39:02 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 20:40:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3cc873a6da53339da9bf7b9f58d1f43cdee9114
Cr-Commit-Position: refs/heads/master@{#371860}

Powered by Google App Engine
This is Rietveld 408576698