blimp/engine/start_engine.sh - Issue 1638153002: Set up an stunnel endpoint for the engine.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/engine/start_engine.sh

Issue 1638153002: Set up an stunnel endpoint for the engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass args, die if either stunnel or engine die, doc updates Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #!/bin/bash

	2

	3 # Copyright 2016 The Chromium Authors. All rights reserved.

	4 # Use of this source code is governed by a BSD-style license that can be

	5 # found in the LICENSE file.

	6

	7 stunnel \

	8 -p /engine/data/stunnel.pem \

	9 -P /engine/stunnel.pid \

	10 -d 25466 -r 25467 -f &

	11 /engine/blimp_engine_app \

	12 --disable-gpu \

	13 --use-remote-compositing \

	14 --disable-cached-picture-raster \

	15 --blimp-client-token-path=/engine/data/client_token \

	16 $@ &

	17 wait -n
	maniscalco 2016/01/28 21:17:24 I think it's worth adding a comment explaining why I think it's worth adding a comment explaining why we use wait -n here (i.e. we want the container to terminate if either stunnel or the engine terminate). marcinjb 2016/01/28 21:41:10 Done. Show quoted text On 2016/01/28 21:17:24, maniscalco wrote: > I think it's worth adding a comment explaining why we use wait -n here (i.e. we > want the container to terminate if either stunnel or the engine terminate). Done.
OLD	NEW

« no previous file with comments | « blimp/engine/Dockerfile ('k') | blimp/tools/bundle-engine.py » ('j') | no next file with comments »