blimp/engine/start_engine.sh - Issue 1638153002: Set up an stunnel endpoint for the engine.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/engine/start_engine.sh

Issue 1638153002: Set up an stunnel endpoint for the engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added documentation on opening a port with Docker Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/bin/bash

	2

	3 # Copyright 2016 The Chromium Authors. All rights reserved.

	4 # Use of this source code is governed by a BSD-style license that can be

	5 # found in the LICENSE file.

	6

	7 stunnel -p /engine/data/stunnel.pem -P /engine/stunnel.pid -d 25467 -r 12345
	maniscalco 2016/01/27 17:02:10 What happens when stunnel fails? Will this script What happens when stunnel fails? Will this script (and the container) be terminated? Seems like we'd want the script to terminate if either stunnel or the engine terminate. That way the higher level will restart the container. marcinjb 2016/01/28 19:29:45 Done. Show quoted text On 2016/01/27 17:02:10, maniscalco wrote: > What happens when stunnel fails? Will this script (and the container) be > terminated? Seems like we'd want the script to terminate if either stunnel or > the engine terminate. That way the higher level will restart the container. Done.
	8 exec /engine/blimp_engine_app \
	maniscalco 2016/01/27 17:02:10 One of the feature we're losing with this change i One of the feature we're losing with this change is the ability to pass arbitrary arguments to the engine when running the container from the command line. Maybe we should make start_engine.sh a more full-featured script and have it pass some/all of its args to blimp_engine_app. Let's chat about this more in person. marcinjb 2016/01/28 19:29:45 Done. Show quoted text On 2016/01/27 17:02:10, maniscalco wrote: > One of the feature we're losing with this change is the ability to pass > arbitrary arguments to the engine when running the container from the command > line. Maybe we should make start_engine.sh a more full-featured script and have > it pass some/all of its args to blimp_engine_app. Let's chat about this more in > person. Done.
	9 --disable-gpu \

	10 --use-remote-compositing \

	11 --disable-cached-picture-raster \

	12 --blimp-client-token-path=/engine/data/client_token

OLD	NEW

« blimp/engine/browser/blimp_engine_session.cc ('K') | « blimp/engine/browser/blimp_engine_session.cc ('k') | blimp/tools/bundle-engine.py » ('j') | no next file with comments »