Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1638123002: Fix template method InstARM32FourAddrFP to only have one definition. (Closed)

Created:
4 years, 11 months ago by Karl
Modified:
4 years, 11 months ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix template method InstARM32FourAddrFP to only have one definition. Fixes case where IceTargetLowring.cpp and IceInstARM32.cpp generate implementations for emitIAS(). BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8c5544b529f63c81e72dc4c70930dd07e5739d85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/IceInstARM32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Karl
4 years, 11 months ago (2016-01-26 23:27:44 UTC) #3
Jim Stichnoth
lgtm
4 years, 11 months ago (2016-01-26 23:29:04 UTC) #4
Karl
4 years, 11 months ago (2016-01-26 23:29:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c5544b529f63c81e72dc4c70930dd07e5739d85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698