Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1638093002: Fix collison with Windows #define RGB macro. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Fix collison with Windows #define RGB macro. kGray and such are much safer. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c812495631df9f059bfd332ffe37e76dd011e96c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M core/include/fpdfdoc/fpdf_ap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 7 chunks +22 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR, busted build.
4 years, 11 months ago (2016-01-26 22:35:47 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as c812495631df9f059bfd332ffe37e76dd011e96c (tree was closed).
4 years, 11 months ago (2016-01-26 22:36:40 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-26 22:48:14 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698