Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1638083002: [iOS] Set --auto-activate-custom-fonts for ibtool compile. (Closed)

Created:
4 years, 11 months ago by justincohen
Modified:
4 years, 10 months ago
Reviewers:
Nico, sdefresne
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

[iOS] Set --auto-activate-custom-fonts for ibtool compile. Adds an extra flag for ibtool when compiling xib and storyboard files. BUG=577711 R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/18ce4ecf6cf2498757b3b61b438d8a4f1ef9e33a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pylib/gyp/mac_tool.py View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 10 (2 generated)
justincohen
sdefresne@ for review, thakis@ for owners. PTAL!
4 years, 11 months ago (2016-01-26 22:29:10 UTC) #2
Nico
https://codereview.chromium.org/1638083002/diff/1/pylib/gyp/mac_tool.py File pylib/gyp/mac_tool.py (right): https://codereview.chromium.org/1638083002/diff/1/pylib/gyp/mac_tool.py#newcode83 pylib/gyp/mac_tool.py:83: '--auto-activate-custom-fonts', '--output-format', do we want this on os x ...
4 years, 11 months ago (2016-01-26 22:55:11 UTC) #3
sdefresne
https://codereview.chromium.org/1638083002/diff/1/pylib/gyp/mac_tool.py File pylib/gyp/mac_tool.py (right): https://codereview.chromium.org/1638083002/diff/1/pylib/gyp/mac_tool.py#newcode83 pylib/gyp/mac_tool.py:83: '--auto-activate-custom-fonts', '--output-format', On 2016/01/26 at 22:55:11, Nico wrote: > ...
4 years, 11 months ago (2016-01-27 09:24:11 UTC) #4
justincohen
I believe interface builder custom font support was added in Xcode 6
4 years, 10 months ago (2016-02-04 19:06:11 UTC) #5
justincohen
Looks like desktop also uses this flags. Here's an example of the latest desktop ibtool ...
4 years, 10 months ago (2016-02-06 15:46:03 UTC) #6
Nico
I'm a bit worried if this breaks running chrome on older OS X's -- does ...
4 years, 10 months ago (2016-02-06 15:52:10 UTC) #7
justincohen
Committed patchset #1 (id:1) manually as 18ce4ecf6cf2498757b3b61b438d8a4f1ef9e33a (presubmit successful).
4 years, 10 months ago (2016-02-06 15:55:16 UTC) #9
justincohen
4 years, 10 months ago (2016-02-06 18:58:16 UTC) #10
Message was sent while issue was closed.
This broke one of the mac bots, but not the others.  How can I tell what version
of Xcode this is using:

https://build.chromium.org/p/chromium/builders/Mac/builds/11730/steps/compile...

Reverted this for now.

Powered by Google App Engine
This is Rietveld 408576698