Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: components/app_modal/javascript_app_modal_dialog.h

Issue 1638013002: Add UMA histograms to track very brief or frequent tabs and JS dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename histograms; ignore blocked JS dialogs Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/app_modal/javascript_app_modal_dialog.h
diff --git a/components/app_modal/javascript_app_modal_dialog.h b/components/app_modal/javascript_app_modal_dialog.h
index 5c81ef7838ee839ba1d5ee67be98bb7c485e10c1..111ba7d444a2209ccb6f97a4fcb79672b8927979 100644
--- a/components/app_modal/javascript_app_modal_dialog.h
+++ b/components/app_modal/javascript_app_modal_dialog.h
@@ -10,6 +10,7 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
+#include "base/time/time.h"
#include "components/app_modal/app_modal_dialog.h"
#include "content/public/browser/javascript_dialog_manager.h"
@@ -83,6 +84,9 @@ class JavaScriptAppModalDialog : public AppModalDialog {
void NotifyDelegate(bool success, const base::string16& prompt_text,
bool suppress_js_messages);
+ void CallDialogClosedCallback(bool success,
+ const base::string16& prompt_text);
+
// A map of extra Chrome-only data associated with the delegate_. The keys
// come from |GetSerializedOriginForWebContents|.
ExtraDataMap* extra_data_map_;
@@ -102,6 +106,8 @@ class JavaScriptAppModalDialog : public AppModalDialog {
base::string16 override_prompt_text_;
bool use_override_prompt_text_;
+ base::TimeTicks creation_time_;
+
DISALLOW_COPY_AND_ASSIGN(JavaScriptAppModalDialog);
};

Powered by Google App Engine
This is Rietveld 408576698