chrome/browser/profiles/profile_manager_browsertest.cc - Issue 1637943003: Remove HostDesktopType from BrowserList::GetInstance()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_manager_browsertest.cc

Issue 1637943003: Remove HostDesktopType from BrowserList::GetInstance() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screen-wrapper-land

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/memory/tab_manager.cc ('K') | « chrome/browser/profiles/profile_list_desktop_browsertest.cc ('k') | chrome/browser/profiles/profile_window_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_manager_browsertest.cc

diff --git a/chrome/browser/profiles/profile_manager_browsertest.cc b/chrome/browser/profiles/profile_manager_browsertest.cc

index 0c5a0651c2d709fc7f21409de9c09dcbf689b699..3623163e96f0185f1cb14670b74c760653c6b13f 100644

--- a/chrome/browser/profiles/profile_manager_browsertest.cc

+++ b/chrome/browser/profiles/profile_manager_browsertest.cc

@@ -324,7 +324,7 @@ IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest,

run_loop.Run();

chrome::HostDesktopType desktop_type = chrome::GetActiveDesktop();

- BrowserList* browser_list = BrowserList::GetInstance(desktop_type);

+ BrowserList* browser_list = BrowserList::GetInstance();

ASSERT_EQ(initial_profile_count + 1, cache.GetNumberOfProfiles());

EXPECT_EQ(1U, browser_list->size());

@@ -393,7 +393,7 @@ IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, MAYBE_EphemeralProfile) {

content::RunMessageLoop();

chrome::HostDesktopType desktop_type = chrome::GetActiveDesktop();

- BrowserList* browser_list = BrowserList::GetInstance(desktop_type);

+ BrowserList* browser_list = BrowserList::GetInstance();

ASSERT_EQ(initial_profile_count + 1, cache.GetNumberOfProfiles());

EXPECT_EQ(1U, browser_list->size());