chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc - Issue 1637943003: Remove HostDesktopType from BrowserList::GetInstance()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

Issue 1637943003: Remove HostDesktopType from BrowserList::GetInstance() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screen-wrapper-land

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/extensions/api/tab_capture/offscreen_tab.cc » ('j') | chrome/browser/memory/tab_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

diff --git a/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc b/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

index 5387534be267f5eb641961a8dcb9462e0437beb7..0a86d3673237600184e4448399b9e16c68234d68 100644

--- a/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

+++ b/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

@@ -145,8 +145,8 @@ IN_PROC_BROWSER_TEST_F(BrowserActionInteractiveTest, TestOpenPopupIncognito) {

EXPECT_FALSE(BrowserActionTestUtil(browser()).HasPopup());

#endif

// Incognito window should have a popup.

- EXPECT_TRUE(BrowserActionTestUtil(BrowserList::GetInstance(

- chrome::GetActiveDesktop())->GetLastActive()).HasPopup());

+ EXPECT_TRUE(BrowserActionTestUtil(BrowserList::GetInstance()->GetLastActive())

+ .HasPopup());

}

// Tests that an extension can open a popup in the last active incognito window