Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc

Issue 1637943003: Remove HostDesktopType from BrowserList::GetInstance() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screen-wrapper-land
Patch Set: mac2 Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h" 5 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/prefs/pref_registry_simple.h" 9 #include "base/prefs/pref_registry_simple.h"
10 #include "base/prefs/testing_pref_service.h" 10 #include "base/prefs/testing_pref_service.h"
(...skipping 21 matching lines...) Expand all
32 size_t count = 0; 32 size_t count = 0;
33 for (TabContentsIterator iterator; !iterator.done(); iterator.Next()) 33 for (TabContentsIterator iterator; !iterator.done(); iterator.Next())
34 ++count; 34 ++count;
35 return count; 35 return count;
36 } 36 }
37 37
38 } // namespace 38 } // namespace
39 39
40 TEST_F(BrowserListTest, TabContentsIteratorVerifyCount) { 40 TEST_F(BrowserListTest, TabContentsIteratorVerifyCount) {
41 // Make sure we have 1 window to start with. 41 // Make sure we have 1 window to start with.
42 EXPECT_EQ(1U, 42 EXPECT_EQ(1U, BrowserList::GetInstance()->size());
43 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->size());
44 43
45 EXPECT_EQ(0U, CountAllTabs()); 44 EXPECT_EQ(0U, CountAllTabs());
46 45
47 // Create more browsers/windows. 46 // Create more browsers/windows.
48 Browser::CreateParams native_params(profile(), 47 Browser::CreateParams native_params(profile(),
49 chrome::HOST_DESKTOP_TYPE_NATIVE); 48 chrome::HOST_DESKTOP_TYPE_NATIVE);
50 scoped_ptr<Browser> browser2( 49 scoped_ptr<Browser> browser2(
51 chrome::CreateBrowserWithTestWindowForParams(&native_params)); 50 chrome::CreateBrowserWithTestWindowForParams(&native_params));
52 // Create browser 3 and 4 on the Ash desktop (the TabContentsIterator 51 // Create browser 3 and 4 on the Ash desktop (the TabContentsIterator
53 // shouldn't see the difference). 52 // shouldn't see the difference).
54 Browser::CreateParams ash_params(profile(), chrome::HOST_DESKTOP_TYPE_ASH); 53 Browser::CreateParams ash_params(profile(), chrome::HOST_DESKTOP_TYPE_ASH);
55 scoped_ptr<Browser> browser3( 54 scoped_ptr<Browser> browser3(
56 chrome::CreateBrowserWithTestWindowForParams(&ash_params)); 55 chrome::CreateBrowserWithTestWindowForParams(&ash_params));
57 scoped_ptr<Browser> browser4( 56 scoped_ptr<Browser> browser4(
58 chrome::CreateBrowserWithTestWindowForParams(&ash_params)); 57 chrome::CreateBrowserWithTestWindowForParams(&ash_params));
59 58
60 // Sanity checks. 59 // Sanity checks.
61 #if defined(OS_CHROMEOS) 60 EXPECT_EQ(4U, BrowserList::GetInstance()->size());
62 // The ash desktop is the native desktop on Chrome OS.
63 EXPECT_EQ(4U,
64 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->size());
65 #else
66 EXPECT_EQ(2U,
67 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->size());
68 EXPECT_EQ(2U,
69 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_ASH)->size());
70 #endif
71 EXPECT_EQ(0, browser()->tab_strip_model()->count()); 61 EXPECT_EQ(0, browser()->tab_strip_model()->count());
72 EXPECT_EQ(0, browser2->tab_strip_model()->count()); 62 EXPECT_EQ(0, browser2->tab_strip_model()->count());
73 EXPECT_EQ(0, browser3->tab_strip_model()->count()); 63 EXPECT_EQ(0, browser3->tab_strip_model()->count());
74 EXPECT_EQ(0, browser4->tab_strip_model()->count()); 64 EXPECT_EQ(0, browser4->tab_strip_model()->count());
75 65
76 EXPECT_EQ(0U, CountAllTabs()); 66 EXPECT_EQ(0U, CountAllTabs());
77 67
78 // Add some tabs. 68 // Add some tabs.
79 for (size_t i = 0; i < 3; ++i) 69 for (size_t i = 0; i < 3; ++i)
80 chrome::NewTab(browser2.get()); 70 chrome::NewTab(browser2.get());
(...skipping 10 matching lines...) Expand all
91 for (size_t i = 0; i < 41; ++i) 81 for (size_t i = 0; i < 41; ++i)
92 chrome::NewTab(browser()); 82 chrome::NewTab(browser());
93 83
94 EXPECT_EQ(42U, CountAllTabs()); 84 EXPECT_EQ(42U, CountAllTabs());
95 // Close all remaining tabs to keep all the destructors happy. 85 // Close all remaining tabs to keep all the destructors happy.
96 browser3->tab_strip_model()->CloseAllTabs(); 86 browser3->tab_strip_model()->CloseAllTabs();
97 } 87 }
98 88
99 TEST_F(BrowserListTest, TabContentsIteratorVerifyBrowser) { 89 TEST_F(BrowserListTest, TabContentsIteratorVerifyBrowser) {
100 // Make sure we have 1 window to start with. 90 // Make sure we have 1 window to start with.
101 EXPECT_EQ(1U, 91 EXPECT_EQ(1U, BrowserList::GetInstance()->size());
102 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->size());
103 92
104 // Create more browsers/windows. 93 // Create more browsers/windows.
105 Browser::CreateParams native_params(profile(), 94 Browser::CreateParams native_params(profile(),
106 chrome::HOST_DESKTOP_TYPE_NATIVE); 95 chrome::HOST_DESKTOP_TYPE_NATIVE);
107 scoped_ptr<Browser> browser2( 96 scoped_ptr<Browser> browser2(
108 chrome::CreateBrowserWithTestWindowForParams(&native_params)); 97 chrome::CreateBrowserWithTestWindowForParams(&native_params));
109 // Create browser 3 on the Ash desktop (the TabContentsIterator shouldn't see 98 // Create browser 3 on the Ash desktop (the TabContentsIterator shouldn't see
110 // the difference). 99 // the difference).
111 Browser::CreateParams ash_params(profile(), chrome::HOST_DESKTOP_TYPE_ASH); 100 Browser::CreateParams ash_params(profile(), chrome::HOST_DESKTOP_TYPE_ASH);
112 scoped_ptr<Browser> browser3( 101 scoped_ptr<Browser> browser3(
113 chrome::CreateBrowserWithTestWindowForParams(&ash_params)); 102 chrome::CreateBrowserWithTestWindowForParams(&ash_params));
114 103
115 // Sanity checks. 104 // Sanity checks.
116 #if defined(OS_CHROMEOS) 105 EXPECT_EQ(3U, BrowserList::GetInstance()->size());
117 // The ash desktop is the native desktop on Chrome OS.
118 EXPECT_EQ(3U,
119 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->size());
120 #else
121 EXPECT_EQ(2U,
122 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->size());
123 EXPECT_EQ(1U,
124 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_ASH)->size());
125 #endif
126 EXPECT_EQ(0, browser()->tab_strip_model()->count()); 106 EXPECT_EQ(0, browser()->tab_strip_model()->count());
127 EXPECT_EQ(0, browser2->tab_strip_model()->count()); 107 EXPECT_EQ(0, browser2->tab_strip_model()->count());
128 EXPECT_EQ(0, browser3->tab_strip_model()->count()); 108 EXPECT_EQ(0, browser3->tab_strip_model()->count());
129 109
130 EXPECT_EQ(0U, CountAllTabs()); 110 EXPECT_EQ(0U, CountAllTabs());
131 111
132 // Add some tabs. 112 // Add some tabs.
133 for (size_t i = 0; i < 3; ++i) 113 for (size_t i = 0; i < 3; ++i)
134 chrome::NewTab(browser2.get()); 114 chrome::NewTab(browser2.get());
135 for (size_t i = 0; i < 2; ++i) 115 for (size_t i = 0; i < 2; ++i)
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 testing_browser_process->SetProfileManager(profile_manager); 187 testing_browser_process->SetProfileManager(profile_manager);
208 188
209 chrome::AttemptRestart(); 189 chrome::AttemptRestart();
210 // Cancel the effects of us calling chrome::AttemptRestart. Otherwise tests 190 // Cancel the effects of us calling chrome::AttemptRestart. Otherwise tests
211 // ran after this one will fail. 191 // ran after this one will fail.
212 browser_shutdown::SetTryingToQuit(false); 192 browser_shutdown::SetTryingToQuit(false);
213 193
214 EXPECT_TRUE(testing_pref_service.GetBoolean(prefs::kWasRestarted)); 194 EXPECT_TRUE(testing_pref_service.GetBoolean(prefs::kWasRestarted));
215 testing_browser_process->SetLocalState(NULL); 195 testing_browser_process->SetLocalState(NULL);
216 } 196 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698