Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Side by Side Diff: chrome/browser/ui/browser_iterator.cc

Issue 1637943003: Remove HostDesktopType from BrowserList::GetInstance() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screen-wrapper-land
Patch Set: mac2 Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser_iterator.h ('k') | chrome/browser/ui/browser_iterator_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_iterator.h" 5 #include "chrome/browser/ui/browser_iterator.h"
6 6
7 // TODO(scottmg): Remove this file entirely. http://crbug.com/558054.
8
7 namespace chrome { 9 namespace chrome {
8 10
9 BrowserIterator::BrowserIterator() 11 BrowserIterator::BrowserIterator()
10 : current_browser_list_(BrowserList::GetInstance(HOST_DESKTOP_TYPE_FIRST)), 12 : browser_list_(BrowserList::GetInstance()),
11 current_iterator_(current_browser_list_->begin()), 13 iterator_(browser_list_->begin()) {
12 next_desktop_type_(
13 static_cast<HostDesktopType>(HOST_DESKTOP_TYPE_FIRST + 1)) {
14 NextBrowserListIfAtEnd();
15 } 14 }
16 15
17 BrowserIterator::~BrowserIterator() { 16 BrowserIterator::~BrowserIterator() {
18 } 17 }
19 18
20 void BrowserIterator::Next() { 19 void BrowserIterator::Next() {
21 ++current_iterator_; 20 ++iterator_;
22 NextBrowserListIfAtEnd();
23 }
24
25 void BrowserIterator::NextBrowserListIfAtEnd() {
26 // Make sure either |current_iterator_| is valid or done().
27 while (current_iterator_ == current_browser_list_->end() &&
28 next_desktop_type_ < HOST_DESKTOP_TYPE_COUNT) {
29 current_browser_list_ = BrowserList::GetInstance(next_desktop_type_);
30 current_iterator_ = current_browser_list_->begin();
31 next_desktop_type_ = static_cast<HostDesktopType>(next_desktop_type_ + 1);
32 }
33 } 21 }
34 22
35 } // namespace chrome 23 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_iterator.h ('k') | chrome/browser/ui/browser_iterator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698