Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1637933002: trace_controller: Makes StopTracing callback ignore empty event strings (Closed)

Created:
4 years, 11 months ago by charliea (OOO until 10-5)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, darin-cc_chromium.org, jam, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

trace_controller: Makes StopTracing callback ignore empty event strings This will give us the flexibility within PowerTracingAgent to signify that an error occurred (such as bad data coming over the serial connection). Committed: https://crrev.com/c214961ef438fcd571f37ff39296feb8df075c65 Cr-Commit-Position: refs/heads/master@{#371587}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M base/trace_event/tracing_agent.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
charliea (OOO until 10-5)
https://codereview.chromium.org/1637933002/diff/20001/base/trace_event/tracing_agent.h File base/trace_event/tracing_agent.h (right): https://codereview.chromium.org/1637933002/diff/20001/base/trace_event/tracing_agent.h#newcode30 base/trace_event/tracing_agent.h:30: // available for the specified agent. Here I chose ...
4 years, 11 months ago (2016-01-26 17:58:57 UTC) #3
oystein (OOO til 10th of July)
lgtm
4 years, 11 months ago (2016-01-26 18:25:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637933002/20001
4 years, 11 months ago (2016-01-26 18:37:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/107086) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 11 months ago (2016-01-26 18:49:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637933002/40001
4 years, 11 months ago (2016-01-26 19:10:08 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2016-01-26 20:40:21 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 20:41:44 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c214961ef438fcd571f37ff39296feb8df075c65
Cr-Commit-Position: refs/heads/master@{#371587}

Powered by Google App Engine
This is Rietveld 408576698