Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 163793004: Turn on icu_use_data_file_flag on CrOS (Closed)

Created:
6 years, 10 months ago by jungshik at Google
Modified:
6 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, vapier
Visibility:
Public.

Description

Turn on icu_use_data_file_flag on CrOS See also https://chromium-review.googlesource.com/#/c/185937/ The switch has to be turned on in two places (chromeos-chrome.ebuild and build/common.gypi). One or the other can get landed separately, though. Note to perf sheriff : chrome (executable) will get smaller by 10MB, but the chrome os image size will not change because what used to be statically linked (icudtl.dat) is now in a separate file in the same location. BUG=72633 TEST=net_unittests:*IDN* and base_unittests:*String* TBR=mark Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251213

Patch Set 1 #

Patch Set 2 : re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/common.gypi View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 10 months ago (2014-02-13 21:45:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/163793004/20001
6 years, 10 months ago (2014-02-13 21:49:48 UTC) #2
commit-bot: I haz the power
Change committed as 251213
6 years, 10 months ago (2014-02-14 00:48:13 UTC) #3
jungshik at Google
6 years, 10 months ago (2014-02-14 00:55:15 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/165593002/ by jshin@chromium.org.

The reason for reverting is:
https://chromium-review.googlesource.com/#/c/185937/ has to go in first. 
.

Powered by Google App Engine
This is Rietveld 408576698