[wasm] Factor out WasmModuleInstance from ModuleEnv.

[wasm] Factor out WasmModuleInstance from ModuleEnv.

R=ahaas@chromium.org,bradnelson@chromium.org
BUG=

Committed: https://crrev.com/1e1f72f3a644c23e1637c136c7b5bb8e57cd63c0
Cr-Commit-Position: refs/heads/master@{#33541}

[bradnelson, 2016-01-26 17:36:07]

lgtm

https://codereview.chromium.org/1637923002/diff/40001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/1637923002/diff/40001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:216: // Set the m
Something seems missing.

https://codereview.chromium.org/1637923002/diff/40001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:234: instance->mem_size = static_cast<size_t>(1)
Use SetMemory rather than reach in?

https://codereview.chromium.org/1637923002/diff/40001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:247: WasmModuleInstance* instance) {
Are you working towards allow us to set these for the asm case?

[titzer, 2016-01-27 09:03:52]

https://codereview.chromium.org/1637923002/diff/40001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/1637923002/diff/40001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:216: // Set the m
On 2016/01/26 17:36:07, bradnelson wrote:
> Something seems missing.

Done.

https://codereview.chromium.org/1637923002/diff/40001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:234: instance->mem_size = static_cast<size_t>(1)
On 2016/01/26 17:36:07, bradnelson wrote:
> Use SetMemory rather than reach in?

Just avoiding chained initialization (avoiding later string pulling when
figuring something out).

https://codereview.chromium.org/1637923002/diff/40001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:247: WasmModuleInstance* instance) {
On 2016/01/26 17:36:07, bradnelson wrote:
> Are you working towards allow us to set these for the asm case?

Mostly just factoring out the code to be shared by Instantiate() and
CompileRun().

[ahaas, 2016-01-27 10:02:40]

lgtm

[titzer, 2016-01-27 10:07:17]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-01-27 10:07:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/1637923002/#ps60001
(title: "Finish comment.")

[commit-bot: I haz the power, 2016-01-27 10:07:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1637923002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1637923002/60001

[commit-bot: I haz the power, 2016-01-27 11:04:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-27 11:04:49]

Description was changed from

==========
[wasm] Factor out WasmModuleInstance from ModuleEnv.

R=ahaas@chromium.org,bradnelson@chromium.org
BUG=
==========

to

==========
[wasm] Factor out WasmModuleInstance from ModuleEnv.

R=ahaas@chromium.org,bradnelson@chromium.org
BUG=

Committed: https://crrev.com/1e1f72f3a644c23e1637c136c7b5bb8e57cd63c0
Cr-Commit-Position: refs/heads/master@{#33541}
==========

[commit-bot: I haz the power, 2016-01-27 11:04:51]

Patchset 4 (id:??) landed as
https://crrev.com/1e1f72f3a644c23e1637c136c7b5bb8e57cd63c0
Cr-Commit-Position: refs/heads/master@{#33541}