Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1637903002: [mojo-bindings] Attribute "native" -> "Native" (Closed)

Created:
4 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 11 months ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-bindings] Attribute "native" -> "Native" We conventionally use CamelCase attribute names. BUG=581169 R=yzshen@chromium.org Committed: https://crrev.com/639bc351c06d73c815672b0dd594a7038e2852ba Cr-Commit-Position: refs/heads/master@{#371528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M mojo/public/interfaces/bindings/tests/test_native_types.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/data.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ken Rockot(use gerrit already)
4 years, 11 months ago (2016-01-26 15:51:26 UTC) #2
yzshen1
lgtm
4 years, 11 months ago (2016-01-26 16:57:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637903002/1
4 years, 11 months ago (2016-01-26 17:04:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 17:10:08 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 17:11:20 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/639bc351c06d73c815672b0dd594a7038e2852ba
Cr-Commit-Position: refs/heads/master@{#371528}

Powered by Google App Engine
This is Rietveld 408576698