Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: Source/core/dom/ContainerNode.h

Issue 16379002: inline WebCore::Node::Node constructor more safely (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/ContainerNode.h
diff --git a/Source/core/dom/ContainerNode.h b/Source/core/dom/ContainerNode.h
index 55c3bf4f55456da9294cc103f6e702a8001ec93c..dae15952379857334d11d094a0f3587961232422 100644
--- a/Source/core/dom/ContainerNode.h
+++ b/Source/core/dom/ContainerNode.h
@@ -26,6 +26,7 @@
#include "core/dom/ExceptionCodePlaceholder.h"
#include "core/dom/Node.h"
+#include "core/dom/TreeScope.h"
adamk 2013/06/04 23:08:08 No need for an #include here
Mostyn Bramley-Moore 2013/06/04 23:46:07 Done.
#include <wtf/OwnPtr.h>
#include <wtf/Vector.h>
@@ -138,7 +139,7 @@ public:
virtual void reportMemoryUsage(MemoryObjectInfo*) const OVERRIDE;
protected:
- ContainerNode(Document*, ConstructionType = CreateContainer);
+ ContainerNode(TreeScope*, ConstructionType = CreateContainer);
static void queuePostAttachCallback(NodeCallback, Node*);
static bool postAttachCallbacksAreSuspended();
@@ -184,8 +185,8 @@ inline const ContainerNode* toContainerNode(const Node* node)
// This will catch anyone doing an unnecessary cast.
void toContainerNode(const ContainerNode*);
-inline ContainerNode::ContainerNode(Document* document, ConstructionType type)
- : Node(document, type)
+inline ContainerNode::ContainerNode(TreeScope* tree_scope, ConstructionType type)
adamk 2013/06/04 23:08:08 tree_scope -> treeScope
Mostyn Bramley-Moore 2013/06/04 23:46:07 Done.
+ : Node(tree_scope, type)
, m_firstChild(0)
, m_lastChild(0)
{

Powered by Google App Engine
This is Rietveld 408576698