Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: Source/core/dom/CharacterData.h

Issue 16379002: inline WebCore::Node::Node constructor more safely (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/ContainerNode.h » ('j') | Source/core/dom/ContainerNode.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/CharacterData.h
diff --git a/Source/core/dom/CharacterData.h b/Source/core/dom/CharacterData.h
index 455058983d99d5bef0e6def940b0d4e57b73c329..395eb96e7bb1755236fdf4c488c8c3fb40f85a5b 100644
--- a/Source/core/dom/CharacterData.h
+++ b/Source/core/dom/CharacterData.h
@@ -24,6 +24,7 @@
#define CharacterData_h
#include "core/dom/Node.h"
+#include "core/dom/TreeScope.h"
adamk 2013/06/04 23:08:08 No need for an #include here
Mostyn Bramley-Moore 2013/06/04 23:46:07 Done.
#include <wtf/text/WTFString.h>
namespace WebCore {
@@ -50,8 +51,8 @@ public:
virtual void reportMemoryUsage(MemoryObjectInfo*) const;
protected:
- CharacterData(Document* document, const String& text, ConstructionType type)
- : Node(document, type)
+ CharacterData(TreeScope* tree_scope, const String& text, ConstructionType type)
adamk 2013/06/04 23:08:08 tree_scope -> treeScope
Mostyn Bramley-Moore 2013/06/04 23:46:07 Done.
+ : Node(tree_scope, type)
, m_data(!text.isNull() ? text : emptyString())
{
ASSERT(type == CreateOther || type == CreateText || type == CreateEditingText);
« no previous file with comments | « no previous file | Source/core/dom/ContainerNode.h » ('j') | Source/core/dom/ContainerNode.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698