Source/core/dom/Text.h - Issue 16379002: inline WebCore::Node::Node constructor more safely

Side by Side Diff: Source/core/dom/Text.h

Issue 16379002: inline WebCore::Node::Node constructor more safely (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: style fixes Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/dom/Notation.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.	4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 bool textRendererIsNeeded(const NodeRenderingContext&);	51 bool textRendererIsNeeded(const NodeRenderingContext&);

52 RenderText* createTextRenderer(RenderArena, RenderStyle);	52 RenderText* createTextRenderer(RenderArena, RenderStyle);

53 void updateTextRenderer(unsigned offsetOfReplacedData, unsigned lengthOfRepl acedData);	53 void updateTextRenderer(unsigned offsetOfReplacedData, unsigned lengthOfRepl acedData);

54	54

55 virtual void attach() OVERRIDE FINAL;	55 virtual void attach() OVERRIDE FINAL;

56	56

57 virtual bool canContainRangeEndPoint() const OVERRIDE FINAL { return true; }	57 virtual bool canContainRangeEndPoint() const OVERRIDE FINAL { return true; }

58 virtual NodeType nodeType() const OVERRIDE;	58 virtual NodeType nodeType() const OVERRIDE;

59	59

60 protected:	60 protected:

61 Text(Document* document, const String& data, ConstructionType type)	61 Text(TreeScope* tree_scope, const String& data, ConstructionType type)
	eseidel 2013/06/05 00:29:12 treeScope treeScope
62 : CharacterData(document, data, type)	62 : CharacterData(tree_scope, data, type)

63 {	63 {

64 ScriptWrappable::init(this);	64 ScriptWrappable::init(this);

65 }	65 }

66	66

67 private:	67 private:

68 virtual String nodeName() const OVERRIDE;	68 virtual String nodeName() const OVERRIDE;

69 virtual PassRefPtr<Node> cloneNode(bool deep) OVERRIDE FINAL;	69 virtual PassRefPtr<Node> cloneNode(bool deep) OVERRIDE FINAL;

70 virtual bool childTypeAllowed(NodeType) const OVERRIDE;	70 virtual bool childTypeAllowed(NodeType) const OVERRIDE;

71	71

72 virtual PassRefPtr<Text> cloneWithData(const String&);	72 virtual PassRefPtr<Text> cloneWithData(const String&);

73	73

74 #ifndef NDEBUG	74 #ifndef NDEBUG

75 virtual void formatForDebugger(char* buffer, unsigned length) const;	75 virtual void formatForDebugger(char* buffer, unsigned length) const;

76 #endif	76 #endif

77 };	77 };

78	78

79 inline Text* toText(Node* node)	79 inline Text* toText(Node* node)

80 {	80 {

81 ASSERT_WITH_SECURITY_IMPLICATION(!node \|\| node->isTextNode());	81 ASSERT_WITH_SECURITY_IMPLICATION(!node \|\| node->isTextNode());

82 return static_cast<Text*>(node);	82 return static_cast<Text*>(node);

83 }	83 }

84	84

85 } // namespace WebCore	85 } // namespace WebCore

86	86

87 #endif // Text_h	87 #endif // Text_h

OLD	NEW