Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1637873002: Remove unused TouchEventCalibrate class. (Closed)

Created:
4 years, 10 months ago by kylechar
Modified:
4 years, 10 months ago
Reviewers:
sadrul, spang
CC:
chromium-reviews, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused TouchEventCalibrate class. The TouchEventCalibrate class was only used with Pixel 1 and Pixel 1 doesn't use X11 anymore. Committed: https://crrev.com/57648f1c8419b764e6b3dab0afcd21abbc45c66e Cr-Commit-Position: refs/heads/master@{#371565}

Patch Set 1 #

Patch Set 2 : Also remove unnused method. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -134 lines) Patch
M ui/aura/window_tree_host_mac.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/window_tree_host_x11.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ui/aura/window_tree_host_x11.cc View 4 chunks +0 lines, -107 lines 0 comments Download
M ui/events/devices/x11/device_data_manager_x11.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/devices/x11/device_data_manager_x11.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
kylechar
4 years, 10 months ago (2016-01-26 15:11:37 UTC) #2
spang
Also remove DeviceDataManagerX11::TouchEventNeedsCalibrate()
4 years, 10 months ago (2016-01-26 17:14:57 UTC) #3
kylechar
On 2016/01/26 at 17:14:57, spang wrote: > Also remove DeviceDataManagerX11::TouchEventNeedsCalibrate() Done.
4 years, 10 months ago (2016-01-26 17:44:03 UTC) #4
sadrul
Cool! lgtm I think we can remove WindowTreeHostX11 after this, and start using WindowTreeHostPlatform with ...
4 years, 10 months ago (2016-01-26 18:27:55 UTC) #5
spang
lgtm
4 years, 10 months ago (2016-01-26 18:34:41 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637873002/20001
4 years, 10 months ago (2016-01-26 18:37:28 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-26 19:35:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637873002/20001
4 years, 10 months ago (2016-01-26 19:38:08 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-26 19:44:43 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-01-26 19:45:46 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57648f1c8419b764e6b3dab0afcd21abbc45c66e
Cr-Commit-Position: refs/heads/master@{#371565}

Powered by Google App Engine
This is Rietveld 408576698