pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart - Issue 1637843002: typeInformation in CreateInstance is a kind of TypeExpression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

Issue 1637843002: typeInformation in CreateInstance is a kind of TypeExpression (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

index 7b3558c194fe9e17997870207d82187674a9d4f1..b4da4ad0875a1d01a8aaebaf72795656b9ecbab1 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

@@ -313,7 +313,7 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {

String visitCreateInstance(CreateInstance node) {

String className = node.classElement.name;

String arguments = node.arguments.map(access).join(' ');

- String typeInformation = node.typeInformation.map(access).join(' ');

+ String typeInformation = optionalAccess(node.typeInformation);

return '(CreateInstance $className ($arguments) ($typeInformation))';

}