typeInformation in CreateInstance is a kind of TypeExpression

pkg/compiler/lib/src/js_backend/codegen/codegen.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_generator;
 
 import 'glue.dart';
 
 import '../../closure.dart' show
     ClosureClassElement;
@@ skipping 813 matching lines @@
     //               needed to reconstruct the instantiated type.
     registry.registerInstantiation(classElement.rawType);
     if (classElement is ClosureClassElement) {
       registry.registerInstantiatedClosure(classElement.methodElement);
     }
     js.Expression instance = new js.New(
         glue.constructorAccess(classElement),
         visitExpressionList(node.arguments))
         .withSourceInformation(node.sourceInformation);
 
-    List<tree_ir.Expression> typeInformation = node.typeInformation;
-    assert(typeInformation.isEmpty ||
-        typeInformation.length == classElement.typeVariables.length);
-    if (typeInformation.isNotEmpty) {
+    tree_ir.Expression typeInformation = node.typeInformation;
+    //assert(typeInformation.isEmpty ||
+    //    typeInformation.length == classElement.typeVariables.length);

[asgerf, 2016/01/26 10:30:00]

Clean up outcommented code.

[sra1, 2016/01/26 22:21:08]

Done. It had to be removed since it can be a variable after GVN

+    if (typeInformation != null) {
       FunctionElement helper = glue.getAddRuntimeTypeInformation();
-      js.Expression typeArguments = new js.ArrayInitializer(
-          visitExpressionList(typeInformation));
+      js.Expression typeArguments = visitExpression(typeInformation);
       return buildStaticHelperInvocation(helper,
           <js.Expression>[instance, typeArguments],
           sourceInformation: node.sourceInformation);
     } else {
       return instance;
     }
   }
 
   @override
   js.Expression visitCreateInvocationMirror(
@@ skipping 131 matching lines @@
       return buildStaticHelperInvocation(
           glue.getTypeArgumentByIndex(),
           [visitExpression(node.target), index],
           sourceInformation: node.sourceInformation);
     }
   }
 
   @override
   js.Expression visitTypeExpression(tree_ir.TypeExpression node) {
     List<js.Expression> arguments = visitExpressionList(node.arguments);
-    return glue.generateTypeRepresentation(node.dartType, arguments, registry);
+    if (node.isForInstance) {
+      registry.registerInstantiatedClass(glue.listClass);
+      return new js.ArrayInitializer(arguments);
+    } else {
+      return glue.generateTypeRepresentation(
+          node.dartType, arguments, registry);
+    }
   }
 
   js.Node handleForeignCode(tree_ir.ForeignCode node) {
     if (node.dependency != null) {
       // Dependency is only used if [node] calls a Dart function. Currently only
       // through foreign function `RAW_DART_FUNCTION_REF`.
       registry.registerStaticUse(
           new StaticUse.staticInvoke(
               node.dependency,
               new CallStructure.unnamed(node.arguments.length)));
@@ skipping 224 matching lines @@
   void registerDefaultParameterValues(ExecutableElement element) {
     if (element is! FunctionElement) return;
     FunctionElement function = element;
     if (function.isStatic) return; // Defaults are inlined at call sites.
     function.functionSignature.forEachOptionalParameter((param) {
       ConstantValue constant = glue.getDefaultParameterValue(param);
       registry.registerCompileTimeConstant(constant);
     });
   }
 }