Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1637803002: arc-settings: Send 12 or 24 hour time display pref to Android (Closed)

Created:
4 years, 11 months ago by benhansen1
Modified:
4 years, 10 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc-settings: Send 12 or 24 hour time display pref to Android Add the syncing to Android of 12 or 24 hour time display preference using the settings bridge. BUG=581258 TEST=Download and open Google Clock app. Toggle "Use 24 hour clock" in chrome://settings and observer change to time display in app. Committed: https://crrev.com/26a0c0023a10a5c9a96cd00dc050fed6e98b97cc Cr-Commit-Position: refs/heads/master@{#372290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/chromeos/arc/settings_bridge.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/settings_bridge.cc View 4 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
benhansen1
PTAL
4 years, 11 months ago (2016-01-26 03:25:47 UTC) #2
Yusuke Sato
lgtm
4 years, 11 months ago (2016-01-26 18:07:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637803002/1
4 years, 11 months ago (2016-01-26 21:17:07 UTC) #5
Yusuke Sato
On 2016/01/26 21:17:07, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 10 months ago (2016-01-28 23:24:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637803002/1
4 years, 10 months ago (2016-01-29 04:38:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 05:10:46 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 05:11:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26a0c0023a10a5c9a96cd00dc050fed6e98b97cc
Cr-Commit-Position: refs/heads/master@{#372290}

Powered by Google App Engine
This is Rietveld 408576698