src/objects-inl.h - Issue 1637753004: [es7] refactor and fix Object.values() / Object.entries()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1637753004: [es7] refactor and fix Object.values() / Object.entries() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: keepin it fresh Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 2e7a9de11df64722ca94e48ca58fe1d8f1f14230..720812316887b43f5c1b944b2242a54f309cc3c5 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -2388,7 +2388,8 @@ void FixedArray::set(int index, Smi* value) {

void FixedArray::set(int index, Object* value) {

DCHECK_NE(GetHeap()->fixed_cow_array_map(), map());

DCHECK(IsFixedArray());

- DCHECK(index >= 0 && index < this->length());

+ DCHECK_GE(index, 0);

+ DCHECK_LT(index, this->length());

int offset = kHeaderSize + index * kPointerSize;

WRITE_FIELD(this, offset, value);

WRITE_BARRIER(GetHeap(), this, offset, value);