[es7] refactor and fix Object.values() / Object.entries()

src/key-accumulator.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_KEY_ACCUMULATOR_H_
 #define V8_KEY_ACCUMULATOR_H_
 
 #include "src/isolate.h"
 #include "src/objects.h"
 
@@ skipping 33 matching lines @@
                AddKeyConversion convert = DO_NOT_CONVERT);
   void AddKeysFromProxy(Handle<JSObject> array);
   Maybe<bool> AddKeysFromProxy(Handle<JSProxy> proxy, Handle<FixedArray> keys);
   void AddElementKeysFromInterceptor(Handle<JSObject> array);
   // Jump to the next level, pushing the current |levelLength_| to
   // |levelLengths_| and adding a new list to |elements_|.
   void NextPrototype();
   // Sort the integer indices in the last list in |elements_|
   void SortCurrentElementsList();
   Handle<FixedArray> GetKeys(GetKeysConversion convert = KEEP_NUMBERS);
+  MaybeHandle<FixedArray> GetValues(Handle<JSReceiver> object,
+                                    GetKeysConversion convert = KEEP_NUMBERS);
+  MaybeHandle<FixedArray> GetEntries(Handle<JSReceiver> object,
+                                     GetKeysConversion convert = KEEP_NUMBERS);

[Camillo Bruni, 2016/02/03 12:03:48]

Do you think we will ever need the convert argument here? If not you can remove
it. For GetKeys we needed it at some point.

[caitp (gmail), 2016/02/03 12:57:30]

it has been removed

   int length() { return length_; }
   Isolate* isolate() { return isolate_; }
 
  private:
   bool AddIntegerKey(uint32_t key);
   bool AddStringKey(Handle<Object> key, AddKeyConversion convert);
   bool AddSymbolKey(Handle<Object> array);
   void SortCurrentElementsListRemoveDuplicates();
+  template <typename F>
+  MaybeHandle<FixedArray> GetKeys_Internal(GetKeysConversion convert,
+                                           bool trivial, F& accumulate);
 
   Isolate* isolate_;
   PropertyFilter filter_;
   // |elements_| contains the sorted element keys (indices) per level.
   std::vector<std::vector<uint32_t>*> elements_;
   // |protoLengths_| contains the total number of keys (elements + properties)
   // per level. Negative values mark counts for a level with keys from a proxy.
   std::vector<int> level_lengths_;
   // |string_properties_| contains the unique String property keys for all
   // levels in insertion order per level.
@@ skipping 12 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(KeyAccumulator);
 };
 
 
 }  // namespace internal
 }  // namespace v8
 
 
 #endif  // V8_KEY_ACCUMULATOR_H_