Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: src/objects.h

Issue 1637753004: [es7] refactor and fix Object.values() / Object.entries() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_H_ 5 #ifndef V8_OBJECTS_H_
6 #define V8_OBJECTS_H_ 6 #define V8_OBJECTS_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 9
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 1942 matching lines...) Expand 10 before | Expand all | Expand 10 after
1953 Handle<JSReceiver> object) { 1953 Handle<JSReceiver> object) {
1954 return GetKeys(object, OWN_ONLY, ALL_PROPERTIES, CONVERT_TO_STRING); 1954 return GetKeys(object, OWN_ONLY, ALL_PROPERTIES, CONVERT_TO_STRING);
1955 } 1955 }
1956 1956
1957 // Computes the enumerable keys for a JSObject. Used for implementing 1957 // Computes the enumerable keys for a JSObject. Used for implementing
1958 // "for (n in object) { }". 1958 // "for (n in object) { }".
1959 MUST_USE_RESULT static MaybeHandle<FixedArray> GetKeys( 1959 MUST_USE_RESULT static MaybeHandle<FixedArray> GetKeys(
1960 Handle<JSReceiver> object, KeyCollectionType type, PropertyFilter filter, 1960 Handle<JSReceiver> object, KeyCollectionType type, PropertyFilter filter,
1961 GetKeysConversion keys_conversion = KEEP_NUMBERS); 1961 GetKeysConversion keys_conversion = KEEP_NUMBERS);
1962 1962
1963 MUST_USE_RESULT static MaybeHandle<FixedArray> GetOwnValues(
1964 Handle<JSReceiver> object, PropertyFilter filter);
1965
1966 MUST_USE_RESULT static MaybeHandle<FixedArray> GetOwnEntries(
1967 Handle<JSReceiver> object, PropertyFilter filter);
1968
1963 // Layout description. 1969 // Layout description.
1964 static const int kPropertiesOffset = HeapObject::kHeaderSize; 1970 static const int kPropertiesOffset = HeapObject::kHeaderSize;
1965 static const int kHeaderSize = HeapObject::kHeaderSize + kPointerSize; 1971 static const int kHeaderSize = HeapObject::kHeaderSize + kPointerSize;
1966 1972
1967 private: 1973 private:
1968 DISALLOW_IMPLICIT_CONSTRUCTORS(JSReceiver); 1974 DISALLOW_IMPLICIT_CONSTRUCTORS(JSReceiver);
1969 }; 1975 };
1970 1976
1971 1977
1972 // The JSObject describes real heap allocated JavaScript objects with 1978 // The JSObject describes real heap allocated JavaScript objects with
(...skipping 8847 matching lines...) Expand 10 before | Expand all | Expand 10 after
10820 } 10826 }
10821 return value; 10827 return value;
10822 } 10828 }
10823 }; 10829 };
10824 10830
10825 10831
10826 } // NOLINT, false-positive due to second-order macros. 10832 } // NOLINT, false-positive due to second-order macros.
10827 } // NOLINT, false-positive due to second-order macros. 10833 } // NOLINT, false-positive due to second-order macros.
10828 10834
10829 #endif // V8_OBJECTS_H_ 10835 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/builtins.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698