Identify context menus being opened via the long press gesture

Add a new source type MENU_SOURCE_LONG_PRESS to identify context menu's being opened via the long press gesture.

For context, please refer to this patch https://codereview.chromium.org/1602903003/, where we display the context menu
on Windows when the long press gesture is released. This patch used the MENU_SOURCE_TOUCH source type in the context menu
params to determine whether a menu is being opened via the long press gesture. Turns out that the MENU_SOURCE_TOUCH is
used in places like devtools to open the context menu, which does not work due to the above patch.

Fix is to add a new menu source type MENU_SOURCE_LONG_PRESS We use this in RenderWidgetHostViewAura to identify context
menus opening via the long press gesture. Added another menu source type MENU_SOURCE_LONG_TAP which indicates menus
opening via the long tap gesture.

This should fix this regression.

BUG=581005
TEST=RenderWidgetHostViewAuraWithViewHarnessTest.ContextMenuTest. Updated this test to test for the MENU_SOURCE_LONG_PRESS gesture
type.

Committed: https://crrev.com/126116ae6dc4769c6864463753cd960d741f1bbe
Cr-Commit-Position: refs/heads/master@{#371672}

[ananta, 2016-01-26 02:10:36]

ananta@chromium.org changed reviewers:
+ jam@chromium.org, tdresser@chromium.org

[ananta, 2016-01-26 02:10:37]

tdresser : please review everything.
jam :- For content owners.

[tdresser, 2016-01-26 13:36:59]

https://codereview.chromium.org/1637743002/diff/20001/ui/base/ui_base_types.h
File ui/base/ui_base_types.h (right):

https://codereview.chromium.org/1637743002/diff/20001/ui/base/ui_base_types.h...
ui/base/ui_base_types.h:48: MENU_SOURCE_TOUCH           = 3,
Would it be clearer to have MENU_SOURCE_LONG_PRESS and MENU_SOURCE_LONG_TAP?

We only open the context menu for touch on long press or long tap, correct?

[ananta, 2016-01-26 20:20:23]

https://codereview.chromium.org/1637743002/diff/20001/ui/base/ui_base_types.h
File ui/base/ui_base_types.h (right):

https://codereview.chromium.org/1637743002/diff/20001/ui/base/ui_base_types.h...
ui/base/ui_base_types.h:48: MENU_SOURCE_TOUCH           = 3,
On 2016/01/26 13:36:59, tdresser wrote:
> Would it be clearer to have MENU_SOURCE_LONG_PRESS and MENU_SOURCE_LONG_TAP?
> 
> We only open the context menu for touch on long press or long tap, correct?

Done.

[tdresser, 2016-01-26 20:26:30]

https://codereview.chromium.org/1637743002/diff/40001/content/renderer/input/...
File content/renderer/input/render_widget_input_handler.cc (right):

https://codereview.chromium.org/1637743002/diff/40001/content/renderer/input/...
content/renderer/input/render_widget_input_handler.cc:302:
context_menu_source_type_ = ui::MENU_SOURCE_TOUCH;
Do we ever use ui::MENU_SOURCE_TOUCH now? I thought we would only use LONG_PRESS
and LONG_TAP.

[ananta, 2016-01-26 20:30:49]

On 2016/01/26 20:26:30, tdresser wrote:
>
https://codereview.chromium.org/1637743002/diff/40001/content/renderer/input/...
> File content/renderer/input/render_widget_input_handler.cc (right):
> 
>
https://codereview.chromium.org/1637743002/diff/40001/content/renderer/input/...
> content/renderer/input/render_widget_input_handler.cc:302:
> context_menu_source_type_ = ui::MENU_SOURCE_TOUCH;
> Do we ever use ui::MENU_SOURCE_TOUCH now? I thought we would only use
LONG_PRESS
> and LONG_TAP.

We do use MENU_SOURCE_TOUCH in the DevToolsHost to bring up the menu. In this
case the menu is brought up in a GestureTapDown event.

[tdresser, 2016-01-26 20:36:35]

LGTM, thanks for clarifying.

[tdresser, 2016-01-26 20:37:01]

Please shorten the CL title, and update the description.

[ananta, 2016-01-26 20:43:47]

Description was changed from

==========
Add a new source type MENU_SOURCE_LONG_PRESS to identify context menu's being
opened via the long press gesture.

For context, please refer to this patch
https://codereview.chromium.org/1602903003/, where we display the context menu
on Windows when the long press gesture is released. This patch used the
MENU_SOURCE_TOUCH source type in the context menu
params to determine whether a menu is being opened via the long press gesture.
Turns out that the MENU_SOURCE_TOUCH is
used in places like devtools to open the context menu, which does not work due
to the above patch.

Fix is to add a new menu source type MENU_SOURCE_LONG_PRESS. We use this in
RenderWidgetHostViewAura to identify context
menus opening via the long press gesture.

This should fix this regression.

BUG=581005
TEST=RenderWidgetHostViewAuraWithViewHarnessTest.ContextMenuTest. Updated this
test to test for the MENU_SOURCE_LONG_PRESS gesture
type.
==========

to

==========
Add a new source type MENU_SOURCE_LONG_PRESS to identify context menu's being
opened via the long press gesture.

For context, please refer to this patch
https://codereview.chromium.org/1602903003/, where we display the context menu
on Windows when the long press gesture is released. This patch used the
MENU_SOURCE_TOUCH source type in the context menu
params to determine whether a menu is being opened via the long press gesture.
Turns out that the MENU_SOURCE_TOUCH is
used in places like devtools to open the context menu, which does not work due
to the above patch.

Fix is to add a new menu source type MENU_SOURCE_LONG_PRESS We use this in
RenderWidgetHostViewAura to identify context
menus opening via the long press gesture. Added another menu source type
MENU_SOURCE_LONG_TAP which indicates menus
opening via the long tap gesture.

This should fix this regression.

BUG=581005
TEST=RenderWidgetHostViewAuraWithViewHarnessTest.ContextMenuTest. Updated this
test to test for the MENU_SOURCE_LONG_PRESS gesture
type.
==========

[ananta, 2016-01-26 22:53:27]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2016-01-26 22:53:28]

+sky for ui owners

[jam, 2016-01-26 23:43:39]

lgtm

[sky, 2016-01-27 01:02:09]

ui/base LGTM

[ananta, 2016-01-27 01:12:49]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2016-01-27 01:13:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1637743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1637743002/40001

[commit-bot: I haz the power, 2016-01-27 01:22:36]

Description was changed from

==========
Add a new source type MENU_SOURCE_LONG_PRESS to identify context menu's being
opened via the long press gesture.

For context, please refer to this patch
https://codereview.chromium.org/1602903003/, where we display the context menu
on Windows when the long press gesture is released. This patch used the
MENU_SOURCE_TOUCH source type in the context menu
params to determine whether a menu is being opened via the long press gesture.
Turns out that the MENU_SOURCE_TOUCH is
used in places like devtools to open the context menu, which does not work due
to the above patch.

Fix is to add a new menu source type MENU_SOURCE_LONG_PRESS We use this in
RenderWidgetHostViewAura to identify context
menus opening via the long press gesture. Added another menu source type
MENU_SOURCE_LONG_TAP which indicates menus
opening via the long tap gesture.

This should fix this regression.

BUG=581005
TEST=RenderWidgetHostViewAuraWithViewHarnessTest.ContextMenuTest. Updated this
test to test for the MENU_SOURCE_LONG_PRESS gesture
type.
==========

to

==========
Add a new source type MENU_SOURCE_LONG_PRESS to identify context menu's being
opened via the long press gesture.

For context, please refer to this patch
https://codereview.chromium.org/1602903003/, where we display the context menu
on Windows when the long press gesture is released. This patch used the
MENU_SOURCE_TOUCH source type in the context menu
params to determine whether a menu is being opened via the long press gesture.
Turns out that the MENU_SOURCE_TOUCH is
used in places like devtools to open the context menu, which does not work due
to the above patch.

Fix is to add a new menu source type MENU_SOURCE_LONG_PRESS We use this in
RenderWidgetHostViewAura to identify context
menus opening via the long press gesture. Added another menu source type
MENU_SOURCE_LONG_TAP which indicates menus
opening via the long tap gesture.

This should fix this regression.

BUG=581005
TEST=RenderWidgetHostViewAuraWithViewHarnessTest.ContextMenuTest. Updated this
test to test for the MENU_SOURCE_LONG_PRESS gesture
type.
==========

[commit-bot: I haz the power, 2016-01-27 01:22:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-27 01:24:49]

Description was changed from

==========
Add a new source type MENU_SOURCE_LONG_PRESS to identify context menu's being
opened via the long press gesture.

For context, please refer to this patch
https://codereview.chromium.org/1602903003/, where we display the context menu
on Windows when the long press gesture is released. This patch used the
MENU_SOURCE_TOUCH source type in the context menu
params to determine whether a menu is being opened via the long press gesture.
Turns out that the MENU_SOURCE_TOUCH is
used in places like devtools to open the context menu, which does not work due
to the above patch.

Fix is to add a new menu source type MENU_SOURCE_LONG_PRESS We use this in
RenderWidgetHostViewAura to identify context
menus opening via the long press gesture. Added another menu source type
MENU_SOURCE_LONG_TAP which indicates menus
opening via the long tap gesture.

This should fix this regression.

BUG=581005
TEST=RenderWidgetHostViewAuraWithViewHarnessTest.ContextMenuTest. Updated this
test to test for the MENU_SOURCE_LONG_PRESS gesture
type.
==========

to

==========
Add a new source type MENU_SOURCE_LONG_PRESS to identify context menu's being
opened via the long press gesture.

For context, please refer to this patch
https://codereview.chromium.org/1602903003/, where we display the context menu
on Windows when the long press gesture is released. This patch used the
MENU_SOURCE_TOUCH source type in the context menu
params to determine whether a menu is being opened via the long press gesture.
Turns out that the MENU_SOURCE_TOUCH is
used in places like devtools to open the context menu, which does not work due
to the above patch.

Fix is to add a new menu source type MENU_SOURCE_LONG_PRESS We use this in
RenderWidgetHostViewAura to identify context
menus opening via the long press gesture. Added another menu source type
MENU_SOURCE_LONG_TAP which indicates menus
opening via the long tap gesture.

This should fix this regression.

BUG=581005
TEST=RenderWidgetHostViewAuraWithViewHarnessTest.ContextMenuTest. Updated this
test to test for the MENU_SOURCE_LONG_PRESS gesture
type.

Committed: https://crrev.com/126116ae6dc4769c6864463753cd960d741f1bbe
Cr-Commit-Position: refs/heads/master@{#371672}
==========

[commit-bot: I haz the power, 2016-01-27 01:24:50]

Patchset 3 (id:??) landed as
https://crrev.com/126116ae6dc4769c6864463753cd960d741f1bbe
Cr-Commit-Position: refs/heads/master@{#371672}