Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 163773004: Remove deprecation of SkBaseDevice::config() so compile can proceed. (Closed)

Created:
6 years, 10 months ago by jvanverth1
Modified:
6 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove deprecation of SkBaseDevice::config() so compile can proceed. Addresses compile error on Ubuntu: [16:09:35.467305] ../../../src/utils/SkDeferredCanvas.cpp: In member function 'virtual SkBitmap::Config DeferredDevice::config() const': [16:09:35.467447] ../../../src/utils/SkDeferredCanvas.cpp:451:38: error: 'virtual SkBitmap::Config SkBaseDevice::config() const' is deprecated (declared at ../../../include/core/SkDevice.h:105) [-Werror=deprecated-declarations] TBR:reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=13455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M include/core/SkDevice.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 10 months ago (2014-02-14 16:31:26 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 16:31:31 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-14 16:31:33 UTC) #3
jvanverth1
Committed patchset #1 manually as r13455.
6 years, 10 months ago (2014-02-14 16:39:14 UTC) #4
bsalomon
On 2014/02/14 16:39:14, JimVV wrote: > Committed patchset #1 manually as r13455. It's TBR= not ...
6 years, 10 months ago (2014-02-14 16:40:45 UTC) #5
jvanverth1
On 2014/02/14 16:40:45, bsalomon wrote: > On 2014/02/14 16:39:14, JimVV wrote: > > Committed patchset ...
6 years, 10 months ago (2014-02-14 16:41:51 UTC) #6
reed1
Looks like I broke something, but perhaps the CL description could mention what didn't compile...
6 years, 10 months ago (2014-02-14 16:49:43 UTC) #7
jvanverth1
6 years, 10 months ago (2014-02-14 17:07:40 UTC) #8
Message was sent while issue was closed.
On 2014/02/14 16:49:43, reed1 wrote:
> Looks like I broke something, but perhaps the CL description could mention
what
> didn't compile...

Added the particular error to the codereview issue.

Powered by Google App Engine
This is Rietveld 408576698