Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Issue 1637643002: Revert of Initial support for turning Skia draws into a JSON document and vice versa. (Closed)

Created:
4 years, 11 months ago by msarett
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Initial support for turning Skia draws into a JSON document and vice versa. (patchset #3 id:80001 of https://codereview.chromium.org/1636563002/ ) Reason for revert: Breaking the CMake build. Original issue's description: > Initial support for turning Skia draws into a JSON document and vice versa. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1636563002 > > Committed: https://skia.googlesource.com/skia/+/3cb582f688822461efa5a034e18008bf2f11e4f8 TBR=jcgregorio@google.com,joshualitt@google.com,mtklein@google.com,ethannicholas@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/7a561230a22a3b312c47cc1e0a14b31965d751c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -984 lines) Patch
D gyp/json.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
M gyp/most.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D src/json/SkJSONCanvas.h View 1 chunk +0 lines, -217 lines 0 comments Download
D src/json/SkJSONCanvas.cpp View 1 chunk +0 lines, -428 lines 0 comments Download
D src/json/SkJSONRenderer.h View 1 chunk +0 lines, -22 lines 0 comments Download
D src/json/SkJSONRenderer.cpp View 1 chunk +0 lines, -289 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
msarett
Created Revert of Initial support for turning Skia draws into a JSON document and vice ...
4 years, 11 months ago (2016-01-25 21:57:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637643002/1
4 years, 11 months ago (2016-01-25 21:57:20 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 21:57:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7a561230a22a3b312c47cc1e0a14b31965d751c8

Powered by Google App Engine
This is Rietveld 408576698