chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java - Issue 1637613003: We have problems with multiple listeners per tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

Issue 1637613003: We have problems with multiple listeners per tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make tab observer list package private. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

index d884142e035071842de18c52bf6a319fb990617d..0a0c8aaed74144febc1387e68f8f598a50b45e6a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

@@ -234,7 +234,7 @@ public class OfflinePageUtils {

}

// Set up the connectivity listener to watch for connectivity.

- tab.addObserver(new OfflinePageTabObserver(activity, tab, connected, bookmarkId));

+ OfflinePageTabObserver.addObserverForTab(activity, tab, connected, bookmarkId);

return;

}

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java ('k') | no next file » | no next file with comments »