Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageConnectivityListener.java

Issue 1637613003: We have problems with multiple listeners per tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make tab observer list package private. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageConnectivityListener.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageConnectivityListener.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageConnectivityListener.java
index 0b07e94654fc0c0182ee16c9340ee5782455d832..c1d04538a77f0190d45bcb8cf8f4e66d180ad0a4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageConnectivityListener.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageConnectivityListener.java
@@ -40,7 +40,6 @@ public class OfflinePageConnectivityListener
Log.d(TAG, "Got connectivity event, connectionType: " + connectionType);
boolean connected = (connectionType != ConnectionType.CONNECTION_NONE
- && connectionType != ConnectionType.CONNECTION_UNKNOWN
&& connectionType != ConnectionType.CONNECTION_BLUETOOTH);
// TODO(petewil): We should consider using the connection quality monitor instead
@@ -53,6 +52,8 @@ public class OfflinePageConnectivityListener
if (connected && mTab != null && !mSeen) {
Log.d(TAG, "Showing reload snackbar");
OfflinePageUtils.showOfflineSnackbarIfNecessary(mActivity, mTab);
+ // We can stop listening for online transitions once we go online.
+ disable();
mSeen = true;
}
}
@@ -61,8 +62,12 @@ public class OfflinePageConnectivityListener
* Enable the listener when we have an offline page showing.
*/
public void enable() {
- NetworkChangeNotifier.addConnectionTypeObserver(this);
- mEnabled = true;
+ if (!mEnabled) {
+ Log.d(TAG, "enabled");
+ NetworkChangeNotifier.addConnectionTypeObserver(this);
+ mEnabled = true;
+ mSeen = false;
+ }
}
/**
@@ -70,6 +75,7 @@ public class OfflinePageConnectivityListener
*/
public void disable() {
if (mEnabled) {
+ Log.d(TAG, "disabled");
NetworkChangeNotifier.removeConnectionTypeObserver(this);
}
mEnabled = false;
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698