Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1637513004: Add missing kasko_features dependency on chrome_nacl_win64. (Closed)

Created:
4 years, 11 months ago by davidben
Modified:
4 years, 11 months ago
Reviewers:
Patrick Monette
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing kasko_features dependency on chrome_nacl_win64. There are two targets with crash_keys.cc, both of which need kasko_features.h generated. Otherwise, building chrome_nacl_win64 in a fresh build directory doesn't work. BUG=none Committed: https://crrev.com/7eaf91f0ca679cbb37dbc6dc55b297ad05e24aa1 Cr-Commit-Position: refs/heads/master@{#371391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/chrome_exe.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
davidben
4 years, 11 months ago (2016-01-25 23:40:09 UTC) #2
Patrick Monette
lgtm
4 years, 11 months ago (2016-01-25 23:52:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637513004/1
4 years, 11 months ago (2016-01-26 00:04:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 00:56:07 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 01:00:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7eaf91f0ca679cbb37dbc6dc55b297ad05e24aa1
Cr-Commit-Position: refs/heads/master@{#371391}

Powered by Google App Engine
This is Rietveld 408576698