Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1637493004: tracing_controller: Adds units to clock sync timeout variable name (Closed)

Created:
4 years, 10 months ago by charliea (OOO until 10-5)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tracing_controller: Adds units to clock sync timeout variable name Committed: https://crrev.com/d4b934b855eff90d5ccf5cf6169ef42407974bc5 Cr-Commit-Position: refs/heads/master@{#371583}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M content/browser/tracing/tracing_controller_impl.cc View 2 chunks +3 lines, -5 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
charliea (OOO until 10-5)
4 years, 10 months ago (2016-01-26 14:45:22 UTC) #2
charliea (OOO until 10-5)
https://codereview.chromium.org/1637493004/diff/20001/content/browser/tracing/tracing_controller_impl.cc File content/browser/tracing/tracing_controller_impl.cc (right): https://codereview.chromium.org/1637493004/diff/20001/content/browser/tracing/tracing_controller_impl.cc#newcode971 content/browser/tracing/tracing_controller_impl.cc:971: FROM_HERE, base::TimeDelta::FromSeconds(kIssueClockSyncTimeoutSeconds), (I also ran git cl format, which ...
4 years, 10 months ago (2016-01-26 14:47:20 UTC) #4
oystein (OOO til 10th of July)
lgtm
4 years, 10 months ago (2016-01-26 18:27:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637493004/20001
4 years, 10 months ago (2016-01-26 18:37:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2016-01-26 20:37:44 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-26 20:39:53 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d4b934b855eff90d5ccf5cf6169ef42407974bc5
Cr-Commit-Position: refs/heads/master@{#371583}

Powered by Google App Engine
This is Rietveld 408576698