chrome/browser/chrome_browser_main.cc - Issue 1637493002: Add SameVersionStartupCounts suffix to startup HardFault and Temperature histograms.

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 1637493002: Add SameVersionStartupCounts suffix to startup HardFault and Temperature histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b1_startup_count_metric

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/startup_metric_utils/browser/startup_metric_utils.h » ('j') | components/startup_metric_utils/browser/startup_metric_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_browser_main.cc

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc

index d0f0964f7a546f2c69d5f8e29eecc0db511d3d7a..36780c6c15a07209afed0c0b9c7781ef9cb0625d 100644

--- a/chrome/browser/chrome_browser_main.cc

+++ b/chrome/browser/chrome_browser_main.cc

@@ -792,10 +792,7 @@ void ChromeBrowserMainParts::RecordBrowserStartupTime() {

// Record collected startup metrics.

startup_metric_utils::RecordBrowserMainMessageLoopStart(

- base::TimeTicks::Now(), is_first_run);

- startup_metric_utils::RecordTimeSinceLastStartup(

- g_browser_process->local_state());

- startup_metric_utils::RecordStartupCount(g_browser_process->local_state());

+ base::TimeTicks::Now(), is_first_run, g_browser_process->local_state());

fdoray 2016/01/25 18:48:00 You will need to update this call site: https://co

gab 2016/01/25 21:20:16 Argh.. @msw: is there an equivalent to local_state

msw 2016/01/25 21:29:44 No, not afaik, but you can just pass a null base::

gab 2016/01/25 21:32:26 Was hoping not to add special code on our side for

}

// -----------------------------------------------------------------------------