Remove use of deprecated CFURLCreateDataAndPropertiesFromResource function.

src/client/mac/handler/minidump_generator.cc

 // Copyright (c) 2006, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 124 matching lines @@
                                   false);
   CFReadStreamRef read_stream = CFReadStreamCreateWithFile(NULL, sys_vers);
   CFRelease(sys_vers);
   if (!read_stream) {
     return;
   }
   if (!CFReadStreamOpen(read_stream)) {
     CFRelease(read_stream);
     return;
   }
-  CFDataRef data = NULL;
-  CFIndex num_bytes_read = 0;
-  const UInt8 *data_bytes =
-    CFReadStreamGetBuffer(read_stream, 0, &num_bytes_read);
-  if (data_bytes) {
-    data = CFDataCreate(NULL, data_bytes, num_bytes_read);
+  // Actual data file tests: Mac at 480 bytes and iOS at 413 bytes.
+  const CFIndex kMaxBufferLength = 1024;

[Mark Mentovai, 2016/02/01 01:03:36]

You can move these two inside the loop.

[ivanpe, 2016/02/01 02:05:20]

Done.

+  UInt8 data_bytes[kMaxBufferLength];
+  CFMutableDataRef data = NULL;
+  while (true) {
+    CFIndex num_bytes_read =
+      CFReadStreamRead(read_stream, data_bytes, kMaxBufferLength);
+    if (num_bytes_read < 0) {
+      if (data) {
+        CFRelease(data);
+        data = NULL;
+      }
+      break;
+    } else if (num_bytes_read == 0) {
+      break;
+    } else if (!data) {
+      data = CFDataCreateMutable(NULL, 0);
+    }
+    CFDataAppendBytes(data, data_bytes, num_bytes_read);
   }
   CFReadStreamClose(read_stream);
   CFRelease(read_stream);
   if (!data) {
     return;
   }
   CFDictionaryRef list = static_cast<CFDictionaryRef>
     (CFPropertyListCreateFromXMLData(NULL, data, kCFPropertyListImmutable,
                                      NULL));
   CFRelease(data);
@@ skipping 1421 matching lines @@
   } else {
     info_ptr->validity = MD_BREAKPAD_INFO_VALID_DUMP_THREAD_ID;
     info_ptr->dump_thread_id = handler_thread_;
     info_ptr->requesting_thread_id = 0;
   }
 
   return true;
 }
 
 }  // namespace google_breakpad