Remove use of deprecated CFURLCreateDataAndPropertiesFromResource function.

src/client/mac/handler/minidump_generator.cc

 // Copyright (c) 2006, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 124 matching lines @@
                                   false);
   CFReadStreamRef read_stream = CFReadStreamCreateWithFile(NULL, sys_vers);
   CFRelease(sys_vers);
   if (!read_stream) {
     return;
   }
   if (!CFReadStreamOpen(read_stream)) {
     CFRelease(read_stream);
     return;
   }
+  // Actual data file tests: Mac at 480 bytes and iOS at 413 bytes,
+  // so setting max length comfortably higher.
+  const CFIndex kMaxBufferLength = 2048;
+  UInt8 data_bytes[kMaxBufferLength];
+  CFIndex num_bytes_read =
+    CFReadStreamRead(read_stream, data_bytes, kMaxBufferLength);
   CFDataRef data = NULL;
-  CFIndex num_bytes_read = 0;
-  const UInt8 *data_bytes =
-    CFReadStreamGetBuffer(read_stream, 0, &num_bytes_read);
-  if (data_bytes) {
+  if (num_bytes_read > 0) {

[Mark Mentovai, 2016/01/26 14:08:50]

If num_bytes_read == kMaxBufferLength, there may have been more data that we
didn’t see. Treat that case as a failure too, unless you implement a read loop
to grab the whole thing.

[ivanpe, 2016/01/27 18:35:42]

Mark, Scott addressed your comment.  Can you please take another look.

     data = CFDataCreate(NULL, data_bytes, num_bytes_read);
   }
   CFReadStreamClose(read_stream);
   CFRelease(read_stream);
   if (!data) {
     return;
   }
   CFDictionaryRef list = static_cast<CFDictionaryRef>
     (CFPropertyListCreateFromXMLData(NULL, data, kCFPropertyListImmutable,
                                      NULL));
@@ skipping 1422 matching lines @@
   } else {
     info_ptr->validity = MD_BREAKPAD_INFO_VALID_DUMP_THREAD_ID;
     info_ptr->dump_thread_id = handler_thread_;
     info_ptr->requesting_thread_id = 0;
   }
 
   return true;
 }
 
 }  // namespace google_breakpad