Show Compositor information in chrome://gpu

content/browser/gpu/gpu_internals_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/gpu/gpu_internals_ui.h"
 
 #include <stddef.h>
 
 #include <string>
 
@@ skipping 290 matching lines @@
   NOTREACHED();
   return nullptr;
 }
 
 base::DictionaryValue* GpuMemoryBufferInfoAsDictionaryValue() {
   base::ListValue* gpu_memory_buffer_info = new base::ListValue();
 
   BrowserGpuMemoryBufferManager* gpu_memory_buffer_manager =
       BrowserGpuMemoryBufferManager::current();
 
+  // Add texture uploads mode.

[reveman, 2016/01/29 15:43:50]

I'd prefer to call it "Tile Initialization Mode" as the use of textures might be
removed in some cases in the future.

[dshwang, 2016/01/29 16:46:14]

I feel a bit weird to "Initialization". one-copy and zero-copy determines how
raster pool updates tile, which affects initialization though.

How about "Tile Update Mode"?

[reveman, 2016/01/29 19:35:36]

Sgtm

+  std::string texture_uploads_mode;
+  if (BrowserGpuMemoryBufferManager::IsNativeGpuMemoryBuffersEnabled()) {

[reveman, 2016/01/29 15:43:50]

This is going to be confusing as native being enabled doesn't mean it's used. It
depends on the platform, driver and what format is used. Is the GMB info below
not sufficient?

[dshwang, 2016/01/29 16:46:14]

It's true. If native is enabled but GMB info don't support any native format, a
user should understand native is not enabled.

or we can add logic that |texture_uploads_mode| is set to "Native, " only if
there is at least one native GMB format supported.

or we can add more complicated logic. query default tile format from cc, and
check the GBM format is supported.

What is better?
the GMB info below doesn't say whether chrome uses software one-copy, native
one-copy, or native zero-copy. the GMB info below says what native GBM format is
supported.

[reveman, 2016/01/29 19:35:36]

These stats are more to help developers than users. I think it's fine having to
look at both GMB info and tile update info to determine what's actually used by
the compositor.
Yes, and in combination with the value above you can determine how tiles are
updated.

+    texture_uploads_mode = "Native, ";
+  } else {
+    texture_uploads_mode = "Software, ";
+  }
+  if (IsZeroCopyUploadEnabled()) {
+    texture_uploads_mode += "Zero-copy ";
+  } else {
+    if (IsPartialRasterEnabled()) {
+      texture_uploads_mode += "Partial ";
+    }
+    texture_uploads_mode += "One-copy ";
+  }

[reveman, 2016/01/29 15:43:50]

Can all this be two flags instead? 1. if zero-copy is enabled, 2. it partial
raster is enabled.

[dshwang, 2016/01/29 16:46:14]

currently chrome don't use partial raster even if using one-copy. I think you
want to know which one-copy or partial raster one-copy is enabled.

+  texture_uploads_mode += "texture uploads";
+  gpu_memory_buffer_info->Append(NewDescriptionValuePair(

[reveman, 2016/01/29 15:43:50]

I don't think this belongs in gpu_memory_buffer_info. This is settings used by
the compositor for initializing tiles and not part of the GMB system.

[dshwang, 2016/01/29 16:46:14]

Ok, let me create new section: "Compositor Information"
Note it cannot belong to "Graphics Feature Status" because description must be
"Hardware accelerated", "Software only", or something.

+      "Texture Uploads Mode",
+      texture_uploads_mode));
+
   for (size_t format = 0;
        format < static_cast<size_t>(gfx::BufferFormat::LAST) + 1; format++) {
     std::string native_usage_support;
     for (size_t usage = 0;
          usage < static_cast<size_t>(gfx::BufferUsage::LAST) + 1; usage++) {
       if (gpu_memory_buffer_manager->IsNativeGpuMemoryBufferConfiguration(
               static_cast<gfx::BufferFormat>(format),
               static_cast<gfx::BufferUsage>(usage)))
         native_usage_support = base::StringPrintf(
             "%s%s %s", native_usage_support.c_str(),
@@ skipping 218 matching lines @@
     : WebUIController(web_ui) {
   web_ui->AddMessageHandler(new GpuMessageHandler());
 
   // Set up the chrome://gpu/ source.
   BrowserContext* browser_context =
       web_ui->GetWebContents()->GetBrowserContext();
   WebUIDataSource::Add(browser_context, CreateGpuHTMLSource());
 }
 
 }  // namespace content